submodule: git submodule dup implementation has been reverted. Assert has been added.

lolgear · lolgear · commit bf1616d1dd17 · 2021-05-26T15:32:05.000+03:00
diff --git a/src/submodule.c b/src/submodule.c
@@ -1856,7 +1856,13 @@ static void submodule_release(git_submodule *sm)
 
 int git_submodule_dup(git_submodule **out, git_submodule *source)
 {
-	return git_object_dup((git_object **)out, (git_object *)source);
+	GIT_ASSERT_ARG(out);
+
+	if (source != NULL)
+		GIT_REFCOUNT_INC(source);
+
+	*out = source;
+	return 0;
 }
 
 void git_submodule_free(git_submodule *sm)

Original file line number	Diff line number	Diff line change
`@@ -1856,7 +1856,13 @@ static void submodule_release(git_submodule *sm)`
`1856`	`1856`
`1857`	`1857`	`int git_submodule_dup(git_submodule *out, git_submodule source)`
`1858`	`1858`	`{`
`1859`		`- return git_object_dup((git_object *)out, (git_object )source);`
	`1859`	`+ GIT_ASSERT_ARG(out);`
	`1860`	`+`
	`1861`	`+ if (source != NULL)`
	`1862`	`+ GIT_REFCOUNT_INC(source);`
	`1863`	`+`
	`1864`	`+ *out = source;`
	`1865`	`+ return 0;`
`1860`	`1866`	`}`
`1861`	`1867`
`1862`	`1868`	`void git_submodule_free(git_submodule *sm)`