Merge pull request libgit2#5445 from lhchavez/fix-5443

Fix segfault when calling git_blame_buffer()

Author: ethomson

src/blame.c

@@ -415,7 +415,7 @@ int git_blame_file(
 
 static bool hunk_is_bufferblame(git_blame_hunk *hunk)
 {
-	return git_oid_is_zero(&hunk->final_commit_id);
+	return hunk && git_oid_is_zero(&hunk->final_commit_id);
 }
 
 static int buffer_hunk_cb(

tests/blame/buffer.c

@@ -17,6 +17,32 @@ void test_blame_buffer__cleanup(void)
 	git_repository_free(g_repo);
 }
 
+void test_blame_buffer__index(void)
+{
+	const git_blame_hunk *hunk;
+	const char *buffer = "Hello\nWorld!";
+
+	/*
+	 * We need to open a different file from the ones used in other tests. Close
+	 * the one opened in test_blame_buffer__initialize() to avoid a leak.
+	 */
+	git_blame_free(g_fileblame);
+	g_fileblame = NULL;
+	cl_git_pass(git_blame_file(&g_fileblame, g_repo, "file.txt", NULL));
+
+	cl_git_pass(git_blame_buffer(&g_bufferblame, g_fileblame, buffer, strlen(buffer)));
+	cl_assert_equal_i(2, git_blame_get_hunk_count(g_bufferblame));
+
+	check_blame_hunk_index(g_repo, g_bufferblame, 0,  1, 1, 0, "836bc00b", "file.txt");
+	hunk = git_blame_get_hunk_byline(g_bufferblame, 1);
+	cl_assert(hunk);
+	cl_assert_equal_s("lhchavez", hunk->final_signature->name);
+	check_blame_hunk_index(g_repo, g_bufferblame, 1,  2, 1, 0, "00000000", "file.txt");
+	hunk = git_blame_get_hunk_byline(g_bufferblame, 2);
+	cl_assert(hunk);
+	cl_assert(hunk->final_signature == NULL);
+}
+
 void test_blame_buffer__added_line(void)
 {
 	const git_blame_hunk *hunk;

tests/resources/blametest.git/objects/83/6bc00b06cb60eb0f629e237ad2b58adb2cfc7e

@@ -0,0 +1,3 @@
+x
��K
+1D]���B�$�OD�{�{:���O���գ�A�y�u���"�RA�ˆ�4�1����f/���]Uϲȣ���X
+�M��Ȗ,�sFc8���S[�}⩼壏�78p�O��.%��f�Z�ua�\u������JF�

tests/resources/blametest.git/objects/a8/ba8436b5d8ccbdfd5be597c194e7bb8e0a092f

@@ -0,0 +1 @@
+x
+)JMU04�`040031QH�+�(a�ٵ�J�5�Ѕ'3����P%�0�� 	���}_ՉΓ�E�{�4�٩�r� -3'�槚�^�uU�'�ݘ��a�n��P5��5��?����p����9���_$*�
�\9�

tests/resources/blametest.git/objects/f9/264f7fbd31ae7a18b7931ed8946fb0aebb0af3

@@ -1 +1 @@
-6653ff42313eb5c82806f145391b18a9699800c7
+836bc00b06cb60eb0f629e237ad2b58adb2cfc7e