streams: openssl: add missing check on OPENSSL_LEGACY_API

laomaiweng · web-flow · commit b1cab70b2c85 · 2018-05-30T02:15:09.000+02:00
The `CRYPTO_THREADID` type is no longer available in OpenSSL ≥ 1.1.0 with deprecated features disabled, and causes build failures. Since the `threadid_cb()` function is only ever called by `git_openssl_set_locking()` when `defined(OPENSSL_LEGACY_API)`, only define it then.
diff --git a/src/streams/openssl.c b/src/streams/openssl.c
@@ -249,7 +249,7 @@ int git_openssl_stream_global_init(void)
 	return 0;
 }
 
-#if defined(GIT_THREADS)
+#if defined(GIT_THREADS) && defined(OPENSSL_LEGACY_API)
 static void threadid_cb(CRYPTO_THREADID *threadid)
 {
 	GIT_UNUSED(threadid);

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,7 @@ int git_openssl_stream_global_init(void)`
`249`	`249`	`return 0;`
`250`	`250`	`}`
`251`	`251`
`252`		`-#if defined(GIT_THREADS)`
	`252`	`+#if defined(GIT_THREADS) && defined(OPENSSL_LEGACY_API)`
`253`	`253`	`static void threadid_cb(CRYPTO_THREADID *threadid)`
`254`	`254`	`{`
`255`	`255`	`GIT_UNUSED(threadid);`