mailmap: git_vector_get already checks bounds

emilio · mystor · commit ae5ee182befb · 2018-06-14T22:43:27.000-07:00
diff --git a/src/mailmap.c b/src/mailmap.c
@@ -267,10 +267,7 @@ git_mailmap_entry *git_mailmap_entry_lookup(
 
 git_mailmap_entry *git_mailmap_entry_byindex(git_mailmap *mailmap, size_t idx)
 {
-	if (idx < git_vector_length(&mailmap->entries))
-		return git_vector_get(&mailmap->entries, idx);
-
-	return NULL;
+	return git_vector_get(&mailmap->entries, idx);
 }
 
 size_t git_mailmap_entry_count(git_mailmap *mailmap)

Original file line number	Diff line number	Diff line change
`@@ -267,10 +267,7 @@ git_mailmap_entry *git_mailmap_entry_lookup(`
`267`	`267`
`268`	`268`	`git_mailmap_entry git_mailmap_entry_byindex(git_mailmap mailmap, size_t idx)`
`269`	`269`	`{`
`270`		`- if (idx < git_vector_length(&mailmap->entries))`
`271`		`- return git_vector_get(&mailmap->entries, idx);`
`272`		`-`
`273`		`- return NULL;`
	`270`	`+ return git_vector_get(&mailmap->entries, idx);`
`274`	`271`	`}`
`275`	`272`
`276`	`273`	`size_t git_mailmap_entry_count(git_mailmap *mailmap)`