mailmap: Undefined or garbage value returned to caller

tiennou · tiennou · commit ad95873bad6c · 2018-08-21T01:41:05.000+02:00
In case there was nothing to parse in the buf, we'd return uninitialized
stack data.
diff --git a/src/mailmap.c b/src/mailmap.c
@@ -225,7 +225,7 @@ int git_mailmap_add_entry(
 
 static int mailmap_add_buffer(git_mailmap *mm, const char *buf, size_t len)
 {
-	int error;
+	int error = 0;
 	git_parse_ctx ctx;
 
 	/* Scratch buffers containing the real parsed names & emails */

Original file line number	Diff line number	Diff line change
`@@ -225,7 +225,7 @@ int git_mailmap_add_entry(`
`225`	`225`
`226`	`226`	`static int mailmap_add_buffer(git_mailmap mm, const char buf, size_t len)`
`227`	`227`	`{`
`228`		`- int error;`
	`228`	`+ int error = 0;`
`229`	`229`	`git_parse_ctx ctx;`
`230`	`230`
`231`	`231`	`/* Scratch buffers containing the real parsed names & emails */`