Skip to content

Commit a088a1f

Browse files
committed
cmake: correct the link stanza for CoreFoundation
LIBRARIES is the (absolute?) path to the library. LDFLAGS is the full linker stanza to correctly link with this lib. By passing LIBRARIES as LIBGIT_LIBS, the linker ends up with the absolute path for the SDK'ed version of CoreFoundation (which doesn't exist), instead of the familiar `-framework CoreFoundation`.
1 parent ef5a385 commit a088a1f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

cmake/Modules/SelectHTTPSBackend.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ IF(HTTPS_BACKEND)
4949

5050
SET(GIT_SECURE_TRANSPORT 1)
5151
LIST(APPEND LIBGIT2_SYSTEM_INCLUDES ${SECURITY_INCLUDE_DIR})
52-
LIST(APPEND LIBGIT2_LIBS ${COREFOUNDATION_LIBRARIES} ${SECURITY_LIBRARIES})
52+
LIST(APPEND LIBGIT2_LIBS ${COREFOUNDATION_LDFLAGS} ${SECURITY_LDFLAGS})
5353
LIST(APPEND LIBGIT2_PC_LIBS ${COREFOUNDATION_LDFLAGS} ${SECURITY_LDFLAGS})
5454
ELSEIF (HTTPS_BACKEND STREQUAL "OpenSSL")
5555
IF (NOT OPENSSL_FOUND)

0 commit comments

Comments
 (0)