sha1: remove generic implementation

Remove the "generic" implementation; it should never be used; it only
existed for a no-dependencies configuration, and our bundled sha1dc
satisfies that requirement _and_ is correct.

Author: ethomson

CMakeLists.txt

@@ -29,7 +29,7 @@ option(USE_NSEC                "Support nanosecond precision file mtimes and cti
 # Backend selection
 option(USE_SSH                 "Link with libssh2 to enable SSH support"               OFF)
 option(USE_HTTPS               "Enable HTTPS support. Can be set to a specific backend" ON)
-option(USE_SHA1                "Enable SHA1. Can be set to CollisionDetection(ON)/HTTPS/Generic" ON)
+option(USE_SHA1                "Enable SHA1. Can be set to CollisionDetection(ON)/HTTPS" ON)
 option(USE_GSSAPI              "Link with libgssapi for SPNEGO auth"      OFF)
    set(USE_HTTP_PARSER         "" CACHE STRING "Specifies the HTTP Parser implementation; either system or builtin.")
    set(REGEX_BACKEND           "" CACHE STRING "Regular expression implementation. One of regcomp_l, pcre2, pcre, regcomp, or builtin.")

cmake/SelectHashes.cmake

@@ -42,7 +42,7 @@ elseif(USE_SHA1 STREQUAL "mbedTLS")
 	list(APPEND LIBGIT2_PC_LIBS ${MBEDTLS_LIBRARIES})
 elseif(USE_SHA1 STREQUAL "Win32")
 	set(GIT_SHA1_WIN32 1)
-elseif(NOT (USE_SHA1 STREQUAL "Generic"))
+else()
 	message(FATAL_ERROR "Asked for unknown SHA1 backend: ${USE_SHA1}")
 endif()
 

src/util/CMakeLists.txt

@@ -41,8 +41,6 @@ elseif(USE_SHA1 STREQUAL "mbedTLS")
 	file(GLOB UTIL_SRC_HASH hash/sha1/mbedtls.*)
 elseif(USE_SHA1 STREQUAL "Win32")
 	file(GLOB UTIL_SRC_HASH hash/sha1/win32.*)
-elseif(USE_SHA1 STREQUAL "Generic")
-	file(GLOB UTIL_SRC_HASH hash/sha1/generic.*)
 else()
 	message(FATAL_ERROR "Asked for unknown SHA1 backend: ${USE_SHA1}")
 endif()

src/util/hash/sha1.h

@@ -12,9 +12,7 @@
 
 typedef struct git_hash_sha1_ctx git_hash_sha1_ctx;
 
-#if defined(GIT_SHA1_COLLISIONDETECT)
-# include "sha1/collisiondetect.h"
-#elif defined(GIT_SHA1_COMMON_CRYPTO)
+#if defined(GIT_SHA1_COMMON_CRYPTO)
 # include "sha1/common_crypto.h"
 #elif defined(GIT_SHA1_OPENSSL)
 # include "sha1/openssl.h"
@@ -23,7 +21,7 @@ typedef struct git_hash_sha1_ctx git_hash_sha1_ctx;
 #elif defined(GIT_SHA1_MBEDTLS)
 # include "sha1/mbedtls.h"
 #else
-# include "sha1/generic.h"
+# include "sha1/collisiondetect.h"
 #endif
 
 #define GIT_HASH_SHA1_SIZE 20