transports: ssh: replace deprecated function libssh2_session_startup

pks-t · pks-t · commit 874ce161ec06 · 2018-03-27T15:03:15.000+01:00
The function `libssh2_session_startup` has been deprecated since libssh2
version 1.2.8 in favor of `libssh2_session_handshake` introduced in the
same version. libssh2 1.2.8 was released in April 2011, so it is already
seven years old. It is available in Debian Wheezy, Ubuntu Trusty and
CentOS 7.4, so the most important and conservative distros already have
it available. As such, it seems safe to just use the new function.
diff --git a/src/transports/ssh.c b/src/transports/ssh.c
@@ -490,7 +490,7 @@ static int _git_ssh_session_create(
 	}
 
 	do {
-		rc = libssh2_session_startup(s, socket->s);
+		rc = libssh2_session_handshake(s, socket->s);
 	} while (LIBSSH2_ERROR_EAGAIN == rc || LIBSSH2_ERROR_TIMEOUT == rc);
 
 	if (rc != LIBSSH2_ERROR_NONE) {

Original file line number	Diff line number	Diff line change
`@@ -490,7 +490,7 @@ static int _git_ssh_session_create(`
`490`	`490`	`}`
`491`	`491`
`492`	`492`	`do {`
`493`		`- rc = libssh2_session_startup(s, socket->s);`
	`493`	`+ rc = libssh2_session_handshake(s, socket->s);`
`494`	`494`	`} while (LIBSSH2_ERROR_EAGAIN == rc \|\| LIBSSH2_ERROR_TIMEOUT == rc);`
`495`	`495`
`496`	`496`	`if (rc != LIBSSH2_ERROR_NONE) {`