mempack functions: return an int

ethomson · ethomson · commit 82050fa1bebb · 2020-01-24T15:12:56.000-06:00
Stop returning a void for functions, future-proofing them to allow them
to fail.
diff --git a/include/git2/sys/mempack.h b/include/git2/sys/mempack.h
@@ -78,8 +78,9 @@ GIT_EXTERN(int) git_mempack_dump(git_buf *pack, git_repository *repo, git_odb_ba
  * semantics to the Git repository.
  *
  * @param backend The mempack backend
+ * @return 0 on success; error code otherwise
  */
-GIT_EXTERN(void) git_mempack_reset(git_odb_backend *backend);
+GIT_EXTERN(int) git_mempack_reset(git_odb_backend *backend);
 
 GIT_END_DECL
 
diff --git a/src/odb_mempack.c b/src/odb_mempack.c
@@ -125,7 +125,7 @@ int git_mempack_dump(git_buf *pack, git_repository *repo, git_odb_backend *_back
 	return err;
 }
 
-void git_mempack_reset(git_odb_backend *_backend)
+int git_mempack_reset(git_odb_backend *_backend)
 {
 	struct memory_packer_db *db = (struct memory_packer_db *)_backend;
 	struct memobject *object = NULL;
@@ -137,6 +137,8 @@ void git_mempack_reset(git_odb_backend *_backend)
 	git_array_clear(db->commits);
 
 	git_oidmap_clear(db->objects);
+
+	return 0;
 }
 
 static void impl__free(git_odb_backend *_backend)

Original file line number	Diff line number	Diff line change
`@@ -78,8 +78,9 @@ GIT_EXTERN(int) git_mempack_dump(git_buf pack, git_repository repo, git_odb_ba`
`78`	`78`	`* semantics to the Git repository.`
`79`	`79`	`*`
`80`	`80`	`* @param backend The mempack backend`
	`81`	`+ * @return 0 on success; error code otherwise`
`81`	`82`	`*/`
`82`		`-GIT_EXTERN(void) git_mempack_reset(git_odb_backend *backend);`
	`83`	`+GIT_EXTERN(int) git_mempack_reset(git_odb_backend *backend);`
`83`	`84`
`84`	`85`	`GIT_END_DECL`
`85`	`86`
Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ int git_mempack_dump(git_buf pack, git_repository repo, git_odb_backend *_back`
`125`	`125`	`return err;`
`126`	`126`	`}`
`127`	`127`
`128`		`-void git_mempack_reset(git_odb_backend *_backend)`
	`128`	`+int git_mempack_reset(git_odb_backend *_backend)`
`129`	`129`	`{`
`130`	`130`	`struct memory_packer_db db = (struct memory_packer_db )_backend;`
`131`	`131`	`struct memobject *object = NULL;`
`@@ -137,6 +137,8 @@ void git_mempack_reset(git_odb_backend *_backend)`
`137`	`137`	`git_array_clear(db->commits);`
`138`	`138`
`139`	`139`	`git_oidmap_clear(db->objects);`
	`140`	`+`
	`141`	`+ return 0;`
`140`	`142`	`}`
`141`	`143`
`142`	`144`	`static void impl__free(git_odb_backend *_backend)`