Skip to content

Commit 7f53d7b

Browse files
authored
revparse: Remove error-prone, redundant test
Originally introduced in: 776a6a8 This test case has recently been fixed in bdab223, but that fix will only last for a year. Next year the same problem will crop up and the test will need to be re-edited. This is not ideal as - This test case becomes an unnecessary burden for developers - Downstream distros or even just users who want to build older versions of libgit2 are guaranteed to have this test fail Furthermore, this test case is entirely unnecessary, as the functionality that was originally (see 776a6a8) intended to be tested is well-covered by subsequent tests which specify a date instead of a "x ago" specification.
1 parent bdab223 commit 7f53d7b

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

tests/libgit2/refs/revparse.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -399,8 +399,6 @@ void test_refs_revparse__date(void)
399399
* a65fedf HEAD@{1335806603 -0900}: commit:
400400
* be3563a HEAD@{1335806563 -0700}: clone: from /Users/ben/src/libgit2/tests/resour
401401
*/
402-
test_object("HEAD@{11 years ago}", "be3563ae3f795b2b4353bcce3a527ad0a4f7f644");
403-
404402
test_object("HEAD@{1 second}", "a65fedf39aefe402d3bb6e24df4d4f5fe4547750");
405403
test_object("HEAD@{1 second ago}", "a65fedf39aefe402d3bb6e24df4d4f5fe4547750");
406404
test_object("HEAD@{2 days ago}", "a65fedf39aefe402d3bb6e24df4d4f5fe4547750");

0 commit comments

Comments
 (0)