Merge pull request libgit2#4797 from bisho/patch-2

pks-t · web-flow · commit 6f525a1931cb · 2018-09-06T11:52:18.000+02:00
Prevent heap-buffer-overflow
diff --git a/src/odb_pack.c b/src/odb_pack.c
@@ -210,7 +210,7 @@ static int packfile_load__cb(void *data, git_buf *path)
 	for (i = 0; i < backend->packs.length; ++i) {
 		struct git_pack_file *p = git_vector_get(&backend->packs, i);
 
-		if (memcmp(p->pack_name, path_str, cmp_len) == 0)
+		if (strncmp(p->pack_name, path_str, cmp_len) == 0)
 			return 0;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,7 @@ static int packfile_load__cb(void data, git_buf path)`
`210`	`210`	`for (i = 0; i < backend->packs.length; ++i) {`
`211`	`211`	`struct git_pack_file *p = git_vector_get(&backend->packs, i);`
`212`	`212`
`213`		`- if (memcmp(p->pack_name, path_str, cmp_len) == 0)`
	`213`	`+ if (strncmp(p->pack_name, path_str, cmp_len) == 0)`
`214`	`214`	`return 0;`
`215`	`215`	`}`
`216`	`216`