winhttp: clarify invalid cert case

ianhattendorf · ianhattendorf · commit 6a10b80201fe · 2020-06-24T08:53:46.000-07:00
diff --git a/src/transports/winhttp.c b/src/transports/winhttp.c
@@ -889,7 +889,7 @@ static int send_request(winhttp_stream *s, size_t len, bool chunked)
 			}
 		}
 
-		if (!request_failed || send_request_error == ERROR_WINHTTP_SECURE_FAILURE) {
+		if (!request_failed || !cert_valid) {
 			git_error_clear();
 			if ((error = certificate_check(s, cert_valid)) < 0) {
 				if (!git_error_last())

Original file line number	Diff line number	Diff line change
`@@ -889,7 +889,7 @@ static int send_request(winhttp_stream *s, size_t len, bool chunked)`
`889`	`889`	`}`
`890`	`890`	`}`
`891`	`891`
`892`		`- if (!request_failed \|\| send_request_error == ERROR_WINHTTP_SECURE_FAILURE) {`
	`892`	`+ if (!request_failed \|\| !cert_valid) {`
`893`	`893`	`git_error_clear();`
`894`	`894`	`if ((error = certificate_check(s, cert_valid)) < 0) {`
`895`	`895`	`if (!git_error_last())`