Skip to content

Commit 681c58c

Browse files
committed
cmake: enable warnings for unused functions
Ever since commit 823c0e9 (Fix broken logic for attr cache invalidation, 2014-04-17), we have completely disabled warnings for unused functions. The only comment that was added back then is about "annoying extra warnings" from Clang, but in fact we shouldn't just ignore warnings about functions which aren't used at all. Instead, the right thing would be to either only conditionally compile functions that aren't used in all configurations or, alternatively, to remove functions that aren't required at all. As remaining instances of unused functions have been removed in the last two commits, re-enable the warning.
1 parent b2af13f commit 681c58c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ ELSE ()
230230
ENABLE_WARNINGS(declaration-after-statement)
231231
ENABLE_WARNINGS(shift-count-overflow)
232232
DISABLE_WARNINGS(unused-const-variable)
233-
DISABLE_WARNINGS(unused-function)
233+
ENABLE_WARNINGS(unused-function)
234234
ENABLE_WARNINGS(format)
235235
ENABLE_WARNINGS(format-security)
236236
ENABLE_WARNINGS(int-conversion)

0 commit comments

Comments
 (0)