Skip to content

Commit 589b812

Browse files
committed
badssl: RC4 should not fail with ECERTIFICATE
Using RC4 is not a _certificate_ problem, it's a cipher problem. The SSL implementation should and will fail with an unrecoverable error (-1). There's no opportunity to accept/continue.
1 parent 89ffa98 commit 589b812

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

tests/online/badssl.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,6 @@ void test_online_badssl__old_cipher(void)
7070
if (!g_has_ssl)
7171
cl_skip();
7272

73-
cl_git_fail_with(GIT_ECERTIFICATE,
74-
git_clone(&g_repo, "https://rc4.badssl.com/fake.git", "./fake", NULL));
75-
cl_git_fail_with(GIT_ECERTIFICATE,
76-
git_clone(&g_repo, "https://rc4.badssl.com/fake.git", "./fake", &opts));
73+
cl_git_fail(git_clone(&g_repo, "https://rc4.badssl.com/fake.git", "./fake", NULL));
74+
cl_git_fail(git_clone(&g_repo, "https://rc4.badssl.com/fake.git", "./fake", &opts));
7775
}

0 commit comments

Comments
 (0)