Merge pull request libgit2#4328 from libgit2/peff/hashcmp-is-memcmp

ethomson · web-flow · commit 577aeef7e96a · 2017-08-14T22:02:26.000+01:00
oid: use memcmp in git_oid__hashcmp
diff --git a/src/oid.h b/src/oid.h
@@ -22,14 +22,7 @@ char *git_oid_allocfmt(const git_oid *id);
 
 GIT_INLINE(int) git_oid__hashcmp(const unsigned char *sha1, const unsigned char *sha2)
 {
-	int i;
-
-	for (i = 0; i < GIT_OID_RAWSZ; i++, sha1++, sha2++) {
-		if (*sha1 != *sha2)
-			return *sha1 - *sha2;
-	}
-
-	return 0;
+	return memcmp(sha1, sha2, GIT_OID_RAWSZ);
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -22,14 +22,7 @@ char git_oid_allocfmt(const git_oid id);`
`22`	`22`
`23`	`23`	`GIT_INLINE(int) git_oid__hashcmp(const unsigned char sha1, const unsigned char sha2)`
`24`	`24`	`{`
`25`		`- int i;`
`26`		`-`
`27`		`- for (i = 0; i < GIT_OID_RAWSZ; i++, sha1++, sha2++) {`
`28`		`- if (sha1 != sha2)`
`29`		`- return sha1 - sha2;`
`30`		`- }`
`31`		`-`
`32`		`- return 0;`
	`25`	`+ return memcmp(sha1, sha2, GIT_OID_RAWSZ);`
`33`	`26`	`}`
`34`	`27`
`35`	`28`	`/*`