Skip to content

Commit 52478d7

Browse files
committed
http: don't allow SSL connections to a proxy
Temporarily disallow SSL connections to a proxy until we can understand the valgrind warnings when tunneling OpenSSL over OpenSSL.
1 parent 41f620d commit 52478d7

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

src/transports/http.c

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -695,7 +695,15 @@ static int load_proxy_config(http_subtransport *t)
695695
return -1;
696696
}
697697

698-
return gitno_connection_data_from_url(&t->proxy.url, t->proxy_opts.url, NULL);
698+
if ((error = gitno_connection_data_from_url(&t->proxy.url, t->proxy_opts.url, NULL)) < 0)
699+
return error;
700+
701+
if (t->proxy.url.use_ssl) {
702+
giterr_set(GITERR_NET, "SSL connections to proxy are not supported");
703+
return -1;
704+
}
705+
706+
return error;
699707
}
700708

701709
static int check_certificate(

0 commit comments

Comments
 (0)