Merge pull request libgit2#5858 from libgit2/ethomson/memleaks

ethomson · web-flow · commit 4bd172087c30 · 2021-05-06T02:28:14.000+01:00
test: clean up memory leaks
diff --git a/src/transports/winhttp.c b/src/transports/winhttp.c
@@ -859,6 +859,7 @@ static int winhttp_connect(
 	if (error < 0)
 		winhttp_close_connection(t);
 
+	git_buf_dispose(&ua);
 	git_buf_dispose(&ipv6);
 	git__free(wide_host);
 	git__free(wide_ua);
diff --git a/tests/path/core.c b/tests/path/core.c
@@ -361,6 +361,9 @@ void test_path_core__validate_workdir_with_core_longpath(void)
 	/* set core.longpaths explicitly off */
 	cl_git_pass(git_config_set_bool(config, "core.longpaths", 0));
 	cl_must_fail(git_path_validate_workdir(repo, "/c/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/longer_than_260.txt"));
+
+	git_config_free(config);
+	git_repository_free(repo);
 #endif
 }
 
diff --git a/tests/refs/basic.c b/tests/refs/basic.c
@@ -80,5 +80,6 @@ void test_refs_basic__longpaths(void)
 
 	git_reference_free(one);
 	git_reference_free(two);
+	git_buf_dispose(&refname);
 #endif
 }

Original file line number	Diff line number	Diff line change
`@@ -361,6 +361,9 @@ void test_path_core__validate_workdir_with_core_longpath(void)`
`361`	`361`	`/* set core.longpaths explicitly off */`
`362`	`362`	`cl_git_pass(git_config_set_bool(config, "core.longpaths", 0));`
`363`	`363`	`cl_must_fail(git_path_validate_workdir(repo, "/c/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/aaaaaaaaa/longer_than_260.txt"));`
	`364`	`+`
	`365`	`+ git_config_free(config);`
	`366`	`+ git_repository_free(repo);`
`364`	`367`	`#endif`
`365`	`368`	`}`
`366`	`369`
Original file line number	Diff line number	Diff line change
`@@ -80,5 +80,6 @@ void test_refs_basic__longpaths(void)`
`80`	`80`
`81`	`81`	`git_reference_free(one);`
`82`	`82`	`git_reference_free(two);`
	`83`	`+ git_buf_dispose(&refname);`
`83`	`84`	`#endif`
`84`	`85`	`}`