Merge pull request libgit2#6506 from libgit2/ethomson/zero_update_tips

ethomson · web-flow · commit 44d3372e4097 · 2023-02-27T12:32:09.000-08:00
remote: always populate old id in update tips
diff --git a/src/libgit2/remote.c b/src/libgit2/remote.c
@@ -1733,7 +1733,7 @@ static int update_ref(
 	const git_remote_callbacks *callbacks)
 {
 	git_reference *ref;
-	git_oid old_id;
+	git_oid old_id = GIT_OID_SHA1_ZERO;
 	int error;
 
 	error = git_reference_name_to_id(&old_id, remote->repo, ref_name);

Original file line number	Diff line number	Diff line change
`@@ -1733,7 +1733,7 @@ static int update_ref(`
`1733`	`1733`	`const git_remote_callbacks *callbacks)`
`1734`	`1734`	`{`
`1735`	`1735`	`git_reference *ref;`
`1736`		`- git_oid old_id;`
	`1736`	`+ git_oid old_id = GIT_OID_SHA1_ZERO;`
`1737`	`1737`	`int error;`
`1738`	`1738`
`1739`	`1739`	`error = git_reference_name_to_id(&old_id, remote->repo, ref_name);`