submodule: git submodule dup out and source parameters have become mandatory.

Author: lolgear

include/git2/submodule.h

@@ -227,7 +227,7 @@ GIT_EXTERN(int) git_submodule_lookup(
  * Create an in-memory copy of a submodule. The copy must be explicitly
  * free'd or it will leak.
  *
- * @param out Pointer to store the copy of the submodule. Cannot be NULL.
+ * @param out Pointer to store the copy of the submodule.
  * @param source Original submodule to copy.
  */
 GIT_EXTERN(int) git_submodule_dup(git_submodule **out, git_submodule *source);

src/submodule.c

@@ -1857,9 +1857,9 @@ static void submodule_release(git_submodule *sm)
 int git_submodule_dup(git_submodule **out, git_submodule *source)
 {
 	GIT_ASSERT_ARG(out);
+	GIT_ASSERT_ARG(source);
 
-	if (source != NULL)
-		GIT_REFCOUNT_INC(source);
+	GIT_REFCOUNT_INC(source);
 
 	*out = source;
 	return 0;