checkout: change symlinked .gitmodules file test to expect failure

carlosmn · carlosmn · commit 3fbfae26fff3 · 2018-05-23T08:47:08.000+02:00
When dealing with `core.proectNTFS` and `core.protectHFS` we do check
against `.gitmodules` but we still have a failing test as the non-filesystem
codepath does not check for it.
diff --git a/tests/checkout/nasty.c b/tests/checkout/nasty.c
@@ -367,7 +367,12 @@ void test_checkout_nasty__symlink3(void)
 void test_checkout_nasty__gitmodules_symlink(void)
 {
 	cl_repo_set_bool(repo, "core.protectHFS", true);
+	test_checkout_fails("refs/heads/gitmodules-symlink", ".gitmodules");
+	cl_repo_set_bool(repo, "core.protectHFS", false);
+
 	cl_repo_set_bool(repo, "core.protectNTFS", true);
+	test_checkout_fails("refs/heads/gitmodules-symlink", ".gitmodules");
+	cl_repo_set_bool(repo, "core.protectNTFS", false);
 
-	test_checkout_passes("refs/heads/gitmodules-symlink", ".gitmodules");
+	test_checkout_fails("refs/heads/gitmodules-symlink", ".gitmodules");
 }

Original file line number	Diff line number	Diff line change
`@@ -367,7 +367,12 @@ void test_checkout_nasty__symlink3(void)`
`367`	`367`	`void test_checkout_nasty__gitmodules_symlink(void)`
`368`	`368`	`{`
`369`	`369`	`cl_repo_set_bool(repo, "core.protectHFS", true);`
	`370`	`+ test_checkout_fails("refs/heads/gitmodules-symlink", ".gitmodules");`
	`371`	`+ cl_repo_set_bool(repo, "core.protectHFS", false);`
	`372`	`+`
`370`	`373`	`cl_repo_set_bool(repo, "core.protectNTFS", true);`
	`374`	`+ test_checkout_fails("refs/heads/gitmodules-symlink", ".gitmodules");`
	`375`	`+ cl_repo_set_bool(repo, "core.protectNTFS", false);`
`371`	`376`
`372`		`- test_checkout_passes("refs/heads/gitmodules-symlink", ".gitmodules");`
	`377`	`+ test_checkout_fails("refs/heads/gitmodules-symlink", ".gitmodules");`
`373`	`378`	`}`