Skip to content

Commit 3b51735

Browse files
committed
attr_file: remove invalid TODO comment
In our attributes pattern parsing code, we have a comment that states we might have to convert '\' characters to '/' to have proper POSIX paths. But in fact, '\' characters are valid inside the string and act as escape mechanism for various characters, which is why we never want to convert those to POSIX directory separators. Furthermore, gitignore patterns are specified to only treat '/' as directory separators. Remove the comment to avoid future confusion.
1 parent b3b6a39 commit 3b51735

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/attr_file.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -743,7 +743,6 @@ int git_attr_fnmatch__parse(
743743
} else {
744744
/* strip '\' that might have been used for internal whitespace */
745745
spec->length = unescape_spaces(spec->pattern);
746-
/* TODO: convert remaining '\' into '/' for POSIX ??? */
747746
}
748747

749748
return 0;

0 commit comments

Comments
 (0)