Skip to content

Commit 2dc7b5e

Browse files
committed
tests: pack: add missing asserts around git_packbuilder_write
1 parent 0edc26c commit 2dc7b5e

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

tests/pack/packbuilder.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ void test_pack_packbuilder__get_hash(void)
145145

146146
seed_packbuilder();
147147

148-
git_packbuilder_write(_packbuilder, ".", 0, NULL, NULL);
148+
cl_git_pass(git_packbuilder_write(_packbuilder, ".", 0, NULL, NULL));
149149
git_oid_fmt(hex, git_packbuilder_hash(_packbuilder));
150150

151151
cl_assert_equal_s(hex, "7f5fa362c664d68ba7221259be1cbd187434b2f0");
@@ -158,7 +158,7 @@ static void test_write_pack_permission(mode_t given, mode_t expected)
158158

159159
seed_packbuilder();
160160

161-
git_packbuilder_write(_packbuilder, ".", given, NULL, NULL);
161+
cl_git_pass(git_packbuilder_write(_packbuilder, ".", given, NULL, NULL));
162162

163163
/* Windows does not return group/user bits from stat,
164164
* files are never executable.
@@ -197,7 +197,7 @@ void test_pack_packbuilder__permissions_readwrite(void)
197197
void test_pack_packbuilder__does_not_fsync_by_default(void)
198198
{
199199
seed_packbuilder();
200-
git_packbuilder_write(_packbuilder, ".", 0666, NULL, NULL);
200+
cl_git_pass(git_packbuilder_write(_packbuilder, ".", 0666, NULL, NULL));
201201
cl_assert_equal_sz(0, p_fsync__cnt);
202202
}
203203

@@ -215,7 +215,7 @@ void test_pack_packbuilder__fsync_global_setting(void)
215215
cl_git_pass(git_libgit2_opts(GIT_OPT_ENABLE_FSYNC_GITDIR, 1));
216216
p_fsync__cnt = 0;
217217
seed_packbuilder();
218-
git_packbuilder_write(_packbuilder, ".", 0666, NULL, NULL);
218+
cl_git_pass(git_packbuilder_write(_packbuilder, ".", 0666, NULL, NULL));
219219
cl_assert_equal_sz(expected_fsyncs, p_fsync__cnt);
220220
}
221221

@@ -224,7 +224,7 @@ void test_pack_packbuilder__fsync_repo_setting(void)
224224
cl_repo_set_bool(_repo, "core.fsyncObjectFiles", true);
225225
p_fsync__cnt = 0;
226226
seed_packbuilder();
227-
git_packbuilder_write(_packbuilder, ".", 0666, NULL, NULL);
227+
cl_git_pass(git_packbuilder_write(_packbuilder, ".", 0666, NULL, NULL));
228228
cl_assert_equal_sz(expected_fsyncs, p_fsync__cnt);
229229
}
230230

0 commit comments

Comments
 (0)