Merge pull request libgit2#4006 from libgit2/cmn/compress-buf-free

Edward Thomson · web-flow · commit 1d683c1d2e36 · 2016-11-14T19:21:56.000Z
Plug a leak in the refs compressor
diff --git a/src/refdb_fs.c b/src/refdb_fs.c
@@ -927,6 +927,7 @@ static int packed_remove_loose(refdb_fs_backend *backend)
 			continue;
 
 		if (error < 0) {
+			git_buf_free(&ref_content);
 			giterr_set(GITERR_REFERENCE, "failed to lock loose reference '%s'", ref->name);
 			return error;
 		}
@@ -957,6 +958,7 @@ static int packed_remove_loose(refdb_fs_backend *backend)
 		p_unlink(lock.path_original);
 	}
 
+	git_buf_free(&ref_content);
 	git_filebuf_cleanup(&lock);
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -927,6 +927,7 @@ static int packed_remove_loose(refdb_fs_backend *backend)`
`927`	`927`	`continue;`
`928`	`928`
`929`	`929`	`if (error < 0) {`
	`930`	`+ git_buf_free(&ref_content);`
`930`	`931`	`giterr_set(GITERR_REFERENCE, "failed to lock loose reference '%s'", ref->name);`
`931`	`932`	`return error;`
`932`	`933`	`}`
`@@ -957,6 +958,7 @@ static int packed_remove_loose(refdb_fs_backend *backend)`
`957`	`958`	`p_unlink(lock.path_original);`
`958`	`959`	`}`
`959`	`960`
	`961`	`+ git_buf_free(&ref_content);`
`960`	`962`	`git_filebuf_cleanup(&lock);`
`961`	`963`	`return 0;`
`962`	`964`	`}`