transport/http: do not return success if we failed to get a scheme

tiennou · tiennou · commit 1c949ce1483c · 2018-08-21T02:11:32.000+02:00
Otherwise we return a NULL context, which will get dereferenced in 
apply_credentials.
diff --git a/src/transports/http.c b/src/transports/http.c
@@ -142,7 +142,7 @@ static int auth_context_match(
 	}
 
 	if (!scheme)
-		return 0;
+		return -1;
 
 	/* See if authentication has already started for this scheme */
 	git_vector_foreach(&t->auth_contexts, i, c) {

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ static int auth_context_match(`
`142`	`142`	`}`
`143`	`143`
`144`	`144`	`if (!scheme)`
`145`		`- return 0;`
	`145`	`+ return -1;`
`146`	`146`
`147`	`147`	`/* See if authentication has already started for this scheme */`
`148`	`148`	`git_vector_foreach(&t->auth_contexts, i, c) {`