Merge pull request libgit2#6246 from bierbaum/wilhelm/fix_extension_validation_string_bug

ethomson · web-flow · commit 0e530061e0eb · 2022-03-22T21:07:53.000-04:00
Fix a string concatenation bug when validating extensions
diff --git a/src/libgit2/repository.c b/src/libgit2/repository.c
@@ -1462,6 +1462,7 @@ static int check_valid_extension(const git_config_entry *entry, void *payload)
 	}
 
 	for (i = 0; i < ARRAY_SIZE(builtin_extensions); i++) {
+		git_str_clear(&cfg);
 		extension = builtin_extensions[i];
 
 		if ((error = git_str_printf(&cfg, "extensions.%s", extension)) < 0)

Original file line number	Diff line number	Diff line change
`@@ -1462,6 +1462,7 @@ static int check_valid_extension(const git_config_entry entry, void payload)`
`1462`	`1462`	`}`
`1463`	`1463`
`1464`	`1464`	`for (i = 0; i < ARRAY_SIZE(builtin_extensions); i++) {`
	`1465`	`+ git_str_clear(&cfg);`
`1465`	`1466`	`extension = builtin_extensions[i];`
`1466`	`1467`
`1467`	`1468`	`if ((error = git_str_printf(&cfg, "extensions.%s", extension)) < 0)`