gitno_extract_url_parts: decode hostnames

ethomson · ethomson · commit 0e4f3d9d4660 · 2018-03-19T16:08:01.000-07:00
RFC 3986 says that hostnames can be percent encoded.  Percent decode
hostnames in our URLs.
diff --git a/src/netops.c b/src/netops.c
@@ -238,7 +238,7 @@ int gitno_extract_url_parts(
 	if (has_host) {
 		const char *url_host = url + u.field_data[UF_HOST].off;
 		size_t url_host_len = u.field_data[UF_HOST].len;
-		git_buf_put(&host, url_host, url_host_len);
+		git_buf_decode_percent(&host, url_host, url_host_len);
 	}
 
 	if (has_port) {

Original file line number	Diff line number	Diff line change
`@@ -238,7 +238,7 @@ int gitno_extract_url_parts(`
`238`	`238`	`if (has_host) {`
`239`	`239`	`const char *url_host = url + u.field_data[UF_HOST].off;`
`240`	`240`	`size_t url_host_len = u.field_data[UF_HOST].len;`
`241`		`- git_buf_put(&host, url_host, url_host_len);`
	`241`	`+ git_buf_decode_percent(&host, url_host, url_host_len);`
`242`	`242`	`}`
`243`	`243`
`244`	`244`	`if (has_port) {`