Merge pull request libgit2#4839 from palmin/ignore-unsupported-http-auth

ethomson · web-flow · commit 0c973356f2ee · 2018-10-07T11:57:06.000+01:00
ignore unsupported http authentication contexts
diff --git a/src/transports/http.c b/src/transports/http.c
@@ -142,7 +142,7 @@ static int auth_context_match(
 	}
 
 	if (!scheme)
-		return -1;
+		return 0;
 
 	/* See if authentication has already started for this scheme */
 	git_vector_foreach(&t->auth_contexts, i, c) {
@@ -188,6 +188,9 @@ static int apply_credentials(git_buf *buf, http_subtransport *t)
 	if (auth_context_match(&context, t, credtype_match, &cred->credtype) < 0)
 		return -1;
 
+	if (!context)
+		return 0;
+
 	return context->next_token(buf, context, cred);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ static int auth_context_match(`
`142`	`142`	`}`
`143`	`143`
`144`	`144`	`if (!scheme)`
`145`		`- return -1;`
	`145`	`+ return 0;`
`146`	`146`
`147`	`147`	`/* See if authentication has already started for this scheme */`
`148`	`148`	`git_vector_foreach(&t->auth_contexts, i, c) {`
`@@ -188,6 +188,9 @@ static int apply_credentials(git_buf buf, http_subtransport t)`
`188`	`188`	`if (auth_context_match(&context, t, credtype_match, &cred->credtype) < 0)`
`189`	`189`	`return -1;`
`190`	`190`
	`191`	`+ if (!context)`
	`192`	`+ return 0;`
	`193`	`+`
`191`	`194`	`return context->next_token(buf, context, cred);`
`192`	`195`	`}`
`193`	`196`