Skip to content

Commit 046b081

Browse files
committed
diff: cleanup hash ctx in git_diff_patchid
After initializing the hash context in `git_diff_patchid`, we never proceed to call `git_hash_ctx_cleanup` on it. While this doesn't really matter on most hash implementations, this causes a memory leak on Win32 due to CNG system requiring a `malloc` call. Fix the memory leak by always calling `git_hash_ctx_cleanup` before exiting.
1 parent e098b5f commit 046b081

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/diff.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -517,5 +517,6 @@ int git_diff_patchid(git_oid *out, git_diff *diff, git_diff_patchid_options *opt
517517
git_oid_cpy(out, &args.result);
518518

519519
out:
520+
git_hash_ctx_cleanup(&args.ctx);
520521
return error;
521522
}

0 commit comments

Comments
 (0)