Use url.URL class instead of url.parse

michielbdejong · michielbdejong · commit a3bbe9171c3f · 2019-06-04T13:12:29.000+02:00
diff --git a/lib/requests/sharing-request.js b/lib/requests/sharing-request.js
@@ -67,7 +67,7 @@ class SharingRequest extends AuthRequest {
     const request = SharingRequest.fromParams(req, res)
 
     const appUrl = request.getAppUrl()
-    const appOrigin = `${appUrl.protocol}//${appUrl.host}`
+    const appOrigin = appUrl.origin
     const serverUrl = new url.URL(req.app.locals.ldp.serverUri)
 
     console.log(new url.URL(request.session.subject._id).origin, serverUrl.origin)
@@ -156,7 +156,7 @@ class SharingRequest extends AuthRequest {
   }
 
   getAppUrl () {
-    return url.parse(this.authQueryParams.redirect_uri)
+    return new url.URL(this.authQueryParams.redirect_uri)
   }
 
   async getProfileGraph (ldp, webId) {

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ class SharingRequest extends AuthRequest {`
`67`	`67`	`const request = SharingRequest.fromParams(req, res)`
`68`	`68`
`69`	`69`	`const appUrl = request.getAppUrl()`
`70`		- const appOrigin = `${appUrl.protocol}//${appUrl.host}`
	`70`	`+ const appOrigin = appUrl.origin`
`71`	`71`	`const serverUrl = new url.URL(req.app.locals.ldp.serverUri)`
`72`	`72`
`73`	`73`	`console.log(new url.URL(request.session.subject._id).origin, serverUrl.origin)`
`@@ -156,7 +156,7 @@ class SharingRequest extends AuthRequest {`
`156`	`156`	`}`
`157`	`157`
`158`	`158`	`getAppUrl () {`
`159`		`- return url.parse(this.authQueryParams.redirect_uri)`
	`159`	`+ return new url.URL(this.authQueryParams.redirect_uri)`
`160`	`160`	`}`
`161`	`161`
`162`	`162`	`async getProfileGraph (ldp, webId) {`