Merge pull request #1164 from solid/fix/#1162

Fixed folders not being created recursively

Author: jaxoncreed

lib/handlers/patch.js

@@ -4,6 +4,7 @@ module.exports = handler
 
 const bodyParser = require('body-parser')
 const fs = require('fs')
+const fx = require('mkdir-recursive')
 const debug = require('../debug').handlers
 const error = require('../http-error')
 const $rdf = require('rdflib')
@@ -55,6 +56,13 @@ async function patchHandler (req, res, next) {
     const patchObject = await parsePatch(url, patch.uri, patch.text)
     await checkPermission(req, patchObject)
 
+    // Check to see if folder exists
+    const pathSplit = path.split('/')
+    const directory = pathSplit.slice(0, pathSplit.length - 1).join('/')
+    if (!fs.existsSync(directory)) {
+      fx.mkdirSync(directory, { recursive: true })
+    }
+
     // Patch the graph and write it back to the file
     const result = await withLock(path, { mustExist: false }, async () => {
       const graph = await readGraph(resource)

package-lock.json

@@ -85,6 +85,7 @@
     "li": "^1.0.1",
     "mashlib": "^0.7.18",
     "mime-types": "^2.1.11",
+    "mkdir-recursive": "^0.4.0",
     "negotiator": "^0.6.0",
     "node-fetch": "^2.1.2",
     "node-forge": "^0.7.4",

package.json

@@ -112,6 +112,17 @@ describe('PATCH', () => {
       text: 'Patch applied successfully',
       result: '@prefix : </write-only.ttl#>.\n@prefix tim: </>.\n\ntim:a tim:b tim:c.\n\ntim:d tim:e tim:f.\n\ntim:x tim:y tim:z.\n\n'
     }))
+
+    describe('on a resource with parent folders that do not exist', describePatch({
+      path: '/folder/cool.ttl',
+      exists: false,
+      patch: `<> solid:patches <https://tim.localhost:7777/folder/cool.ttl>;
+        solid:inserts { <x> <y> <z>. }.`
+    }, {
+      status: 200,
+      text: 'Patch applied successfully',
+      result: '@prefix : <#>.\n@prefix fol: <./>.\n\nfol:x fol:y fol:z.\n\n'
+    }))
   })
 
   describe('with insert and where', () => {