Set no quota if the predicate isn't there

Author: kjetilk

lib/utils.js

@@ -250,6 +250,7 @@ function routeResolvedFile (router, path, file, appendFileName = true) {
 
 function getQuota (root, serverUri) {
   const filename = path.join(root, 'settings/serverSide.ttl')
+  var quota = Infinity
   var prefs
   try {
     prefs = fs.readFileSync(filename, 'utf8')
@@ -261,19 +262,21 @@ function getQuota (root, serverUri) {
   const storageUri = serverUri + '/'
   $rdf.parse(prefs, graph, storageUri, 'text/turtle')
   const lit = graph.each($rdf.sym(storageUri), ns.solid('storageQuota'), undefined)[0]
-  var quota = lit.value
-  const unitUri = 'http://www.w3.invalid/ns#'
-  // The following should be encoded in the ontology
-  switch (lit.datatype.value) {
-    case unitUri + 'kilobyte':
-      quota *= 1000
-      break
-    case unitUri + 'megabyte':
-      quota *= 1000000
-      break
-    case unitUri + 'gigabyte':
-      quota *= 1000000000
-      break
+  if (lit) {
+    quota = lit.value
+    const unitUri = 'http://www.w3.invalid/ns#'
+    // The following should be encoded in the ontology
+    switch (lit.datatype.value) {
+      case unitUri + 'kilobyte':
+        quota *= 1000
+        break
+      case unitUri + 'megabyte':
+        quota *= 1000000
+        break
+      case unitUri + 'gigabyte':
+        quota *= 1000000000
+        break
+    }
   }
   return quota
 }

test/integration/quota-test.js

@@ -5,7 +5,7 @@ const read = require('../utils').read
 const root = 'accounts-acl/config/templates/new-account/'
 // const $rdf = require('rdflib')
 
-describe('Quota', function () {
+describe('Get Quota', function () {
   var prefs = read(path.join(root, 'settings/serverSide.ttl'))
   it('Check that the file is readable and has predicate', function () {
     expect(prefs).to.be.a('string')
@@ -17,4 +17,7 @@ describe('Quota', function () {
   it('Get the quota with non-existant file', function () {
     expect(getQuota(path.join('nowhere/', root), 'https://localhost')).to.equal(Infinity)
   })
+  it('Get the quota when the predicate is not present', function () {
+    expect(getQuota('test/resources/accounts-acl/quota', 'https://localhost')).to.equal(Infinity)
+  })
 })

test/resources/accounts-acl/quota/settings/serverSide.ttl

@@ -0,0 +1,11 @@
+@prefix dct: <http://purl.org/dc/terms/>.
+@prefix pim: <http://www.w3.org/ns/pim/space#>.
+@prefix solid: <http://www.w3.org/ns/solid/terms#>.
+@prefix unit: <http://www.w3.invalid/ns#>.
+
+<>
+  a pim:ConfigurationFile;
+
+  dct:description "Administrative settings for the server that are only readable to the user." .
+
+# Nothing here...