extract to the function

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Author: alperozturk96

app/src/main/java/it/niedermann/owncloud/notes/edit/BaseNoteFragment.java

@@ -281,20 +281,21 @@ public boolean onOptionsItemSelected(MenuItem item) {
             shareNote();
             return false;
         } else if (itemId == MENU_ID_PIN) {
-            return pinNoteToHome();
+            pinNoteToHome();
+            return true;
         }
 
         return super.onOptionsItemSelected(item);
     }
 
-    private boolean pinNoteToHome() {
+    private void pinNoteToHome() {
         if (Build.VERSION.SDK_INT < Build.VERSION_CODES.O) {
-            return true;
+            return;
         }
 
         if (!ShortcutManagerCompat.isRequestPinShortcutSupported(requireContext())) {
             Log.i(TAG, "RequestPinShortcut is not supported");
-            return true;
+            return;
         }
 
         final var iconId = note.getFavorite() ? R.drawable.ic_star_yellow_24dp : R.drawable.ic_star_border_grey_ccc_24dp;
@@ -316,8 +317,6 @@ private boolean pinNoteToHome() {
                 .getBroadcast(requireContext(), 0, broadcastIntent, intentFlag)
                 .getIntentSender();
         ShortcutManagerCompat.requestPinShortcut(requireContext(), pinShortcutInfo, intentSender);
-
-        return true;
     }
 
     protected void shareNote() {