try to fix e2e tests

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>

Author: Chartman123

playwright/e2e/create-empty-form.spec.ts

@@ -4,15 +4,16 @@
  */
 
 import { expect, mergeTests } from '@playwright/test'
-import { test as randomUserTest } from '../support/fixtures/random-user'
-import { test as appNavigationTest } from '../support/fixtures/navigation'
-import { test as formTest } from '../support/fixtures/form'
+import { test as formTest } from '../support/fixtures/form.ts'
+import { test as appNavigationTest } from '../support/fixtures/navigation.ts'
+import { test as randomUserTest } from '../support/fixtures/random-user.ts'
 
 const test = mergeTests(randomUserTest, appNavigationTest, formTest)
 
 test.beforeEach(async ({ page }) => {
-	await page.goto('apps/forms')
-	await page.waitForURL(/apps\/forms$/)
+	// use absolute path and wait until network is idle to avoid flaky load waits
+	await page.goto('apps/forms', { waitUntil: 'networkidle' })
+	await page.waitForURL(/apps\/forms\/$/)
 })
 
 test.describe('No forms created - empty content', () => {

playwright/e2e/form-description.spec.ts

@@ -4,17 +4,17 @@
  */
 
 import { expect, mergeTests } from '@playwright/test'
-import { test as randomUserTest } from '../support/fixtures/random-user'
-import { test as appNavigationTest } from '../support/fixtures/navigation'
-import { test as topBarTest } from '../support/fixtures/topBar'
-import { test as formTest } from '../support/fixtures/form'
-import { FormsView } from '../support/sections/TopBarSection'
+import { test as formTest } from '../support/fixtures/form.ts'
+import { test as appNavigationTest } from '../support/fixtures/navigation.ts'
+import { test as randomUserTest } from '../support/fixtures/random-user.ts'
+import { test as topBarTest } from '../support/fixtures/topBar.ts'
+import { FormsView } from '../support/sections/TopBarSection.ts'
 
 const test = mergeTests(randomUserTest, appNavigationTest, formTest, topBarTest)
 
 test.beforeEach(async ({ page }) => {
-	await page.goto('apps/forms')
-	await page.waitForURL(/apps\/forms$/)
+	await page.goto('apps/forms', { waitUntil: 'networkidle' })
+	await page.waitForURL(/apps\/forms\/$/)
 })
 
 test.describe('Form description', () => {

playwright/e2e/ime-input.spec.ts

@@ -4,16 +4,16 @@
  */
 
 import { expect, mergeTests } from '@playwright/test'
-import { test as randomUserTest } from '../support/fixtures/random-user'
-import { test as appNavigationTest } from '../support/fixtures/navigation'
-import { test as formTest } from '../support/fixtures/form'
-import { QuestionType } from '../support/sections/QuestionType'
+import { test as formTest } from '../support/fixtures/form.ts'
+import { test as appNavigationTest } from '../support/fixtures/navigation.ts'
+import { test as randomUserTest } from '../support/fixtures/random-user.ts'
+import { QuestionType } from '../support/sections/QuestionType.ts'
 
 const test = mergeTests(randomUserTest, appNavigationTest, formTest)
 
 test.beforeEach(async ({ page }) => {
-	await page.goto('apps/forms')
-	await page.waitForURL(/apps\/forms$/)
+	await page.goto('apps/forms', { waitUntil: 'networkidle' })
+	await page.waitForURL(/apps\/forms\/$/)
 })
 
 test(

playwright/support/fixtures/form.ts

@@ -4,7 +4,7 @@
  */
 
 import { test as baseTest } from '@playwright/test'
-import { FormSection } from '../sections/FormSection'
+import { FormSection } from '../sections/FormSection.ts'
 
 interface FormFixture {
 	form: FormSection

playwright/support/fixtures/navigation.ts

@@ -4,7 +4,7 @@
  */
 
 import { test as baseTest } from '@playwright/test'
-import { AppNavigationSection } from '../sections/AppNavigationSection'
+import { AppNavigationSection } from '../sections/AppNavigationSection.ts'
 
 interface AppNavigationFixture {
 	appNavigation: AppNavigationSection

playwright/support/fixtures/random-user.ts

@@ -3,8 +3,8 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-import { test as base } from '@playwright/test'
 import { createRandomUser, login } from '@nextcloud/e2e-test-server/playwright'
+import { test as base } from '@playwright/test'
 
 /**
  * This test fixture ensures a new random user is created and used for the test (current page)

playwright/support/fixtures/topBar.ts

@@ -4,7 +4,7 @@
  */
 
 import { test as baseTest } from '@playwright/test'
-import { TopBarSection } from '../sections/TopBarSection'
+import { TopBarSection } from '../sections/TopBarSection.ts'
 
 interface TopBarFixture {
 	topBar: TopBarSection

playwright/support/sections/AppNavigationSection.ts

@@ -11,7 +11,6 @@ export class AppNavigationSection {
 	public readonly ownFormsLocator: Locator
 	public readonly sharedFormsLocator: Locator
 
-	// eslint-disable-next-line no-useless-constructor
 	constructor(public readonly page: Page) {
 		this.navigationLocator = this.page.getByRole('navigation', {
 			name: 'Forms navigation',

playwright/support/sections/FormSection.ts

@@ -4,16 +4,16 @@
  */
 
 import type { Locator, Page, Response } from '@playwright/test'
-import type { QuestionType } from './QuestionType'
-import { QuestionSection } from './QuestionSection'
+import type { QuestionType } from './QuestionType.ts'
+
+import { QuestionSection } from './QuestionSection.ts'
 
 export class FormSection {
 	public readonly mainContent: Locator
 	public readonly titleField: Locator
 	public readonly descriptionField: Locator
 	public readonly newQuestionButton: Locator
 
-	// eslint-disable-next-line no-useless-constructor
 	constructor(public readonly page: Page) {
 		this.mainContent = this.page.getByRole('main')
 		this.newQuestionButton = this.page.getByRole('button', {

playwright/support/sections/QuestionSection.ts

@@ -10,7 +10,6 @@ export class QuestionSection {
 	public readonly newAnswerInput: Locator
 	public readonly answerInputs: Locator
 
-	// eslint-disable-next-line no-useless-constructor
 	constructor(
 		public readonly page: Page,
 		public readonly section: Locator,