Address code review feedback: fix task casting, security validation, and deprecated APIs

Agent-Logs-Url: https://github.com/nativescript-community/https/sessions/fc9101f9-5596-43a3-ab69-ff9c48eeef06

Co-authored-by: farfromrefug <655344+farfromrefug@users.noreply.github.com>

Author: Copilot

packages/https/platforms/ios/src/AlamofireWrapper.swift

@@ -95,8 +95,15 @@ public class AlamofireWrapper: NSObject {
         var afRequest: DataRequest = session.request(request)
 
         // Apply server trust evaluation if security policy is set
-        if let secPolicy = securityPolicy {
-            afRequest = afRequest.validate(evaluator: secPolicy)
+        if let secPolicy = securityPolicy, let host = url.host {
+            afRequest = afRequest.validate { _, response, _ in
+                do {
+                    try secPolicy.evaluate(response.serverTrust!, forHost: host)
+                    return .success(Void())
+                } catch {
+                    return .failure(error)
+                }
+            }
         }
 
         // Upload progress
@@ -115,24 +122,25 @@ public class AlamofireWrapper: NSObject {
 
         // Response handling
         afRequest.response(queue: .main) { response in
-            guard let task = response.request?.task else {
+            let task = response.request?.task as? URLSessionDataTask
+            guard let task = task else {
                 let error = NSError(domain: "AlamofireWrapper", code: -1, userInfo: [NSLocalizedDescriptionKey: "No task available"])
                 failure(nil, error)
                 return
             }
 
             if let error = response.error {
                 let nsError = self.createNSError(from: error, response: response.response, data: response.data)
-                failure(task as? URLSessionDataTask, nsError)
+                failure(task, nsError)
                 return
             }
 
             // Deserialize response based on responseSerializer
             if let data = response.data {
                 let result = self.responseSerializer.deserialize(data: data, response: response.response)
-                success(task as? URLSessionDataTask ?? URLSessionDataTask(), result)
+                success(task, result)
             } else {
-                success(task as? URLSessionDataTask ?? URLSessionDataTask(), nil)
+                success(task, nil)
             }
         }
 
@@ -178,8 +186,15 @@ public class AlamofireWrapper: NSObject {
         }, with: request)
 
         // Apply server trust evaluation if security policy is set
-        if let secPolicy = securityPolicy {
-            afRequest = afRequest.validate(evaluator: secPolicy)
+        if let secPolicy = securityPolicy, let host = url.host {
+            afRequest = afRequest.validate { _, response, _ in
+                do {
+                    try secPolicy.evaluate(response.serverTrust!, forHost: host)
+                    return .success(Void())
+                } catch {
+                    return .failure(error)
+                }
+            }
         }
 
         // Upload progress
@@ -191,24 +206,25 @@ public class AlamofireWrapper: NSObject {
 
         // Response handling
         afRequest.response(queue: .main) { response in
-            guard let task = response.request?.task else {
+            let task = response.request?.task as? URLSessionDataTask
+            guard let task = task else {
                 let error = NSError(domain: "AlamofireWrapper", code: -1, userInfo: [NSLocalizedDescriptionKey: "No task available"])
                 failure(nil, error)
                 return
             }
 
             if let error = response.error {
                 let nsError = self.createNSError(from: error, response: response.response, data: response.data)
-                failure(task as? URLSessionDataTask, nsError)
+                failure(task, nsError)
                 return
             }
 
             // Deserialize response based on responseSerializer
             if let data = response.data {
                 let result = self.responseSerializer.deserialize(data: data, response: response.response)
-                success(task as? URLSessionDataTask ?? URLSessionDataTask(), result)
+                success(task, result)
             } else {
-                success(task as? URLSessionDataTask ?? URLSessionDataTask(), nil)
+                success(task, nil)
             }
         }
 
@@ -227,8 +243,15 @@ public class AlamofireWrapper: NSObject {
         var afRequest = session.upload(fileURL, with: request)
 
         // Apply server trust evaluation if security policy is set
-        if let secPolicy = securityPolicy {
-            afRequest = afRequest.validate(evaluator: secPolicy)
+        if let secPolicy = securityPolicy, let host = request.url?.host {
+            afRequest = afRequest.validate { _, response, _ in
+                do {
+                    try secPolicy.evaluate(response.serverTrust!, forHost: host)
+                    return .success(Void())
+                } catch {
+                    return .failure(error)
+                }
+            }
         }
 
         // Upload progress
@@ -267,8 +290,15 @@ public class AlamofireWrapper: NSObject {
         var afRequest = session.upload(bodyData, with: request)
 
         // Apply server trust evaluation if security policy is set
-        if let secPolicy = securityPolicy {
-            afRequest = afRequest.validate(evaluator: secPolicy)
+        if let secPolicy = securityPolicy, let host = request.url?.host {
+            afRequest = afRequest.validate { _, response, _ in
+                do {
+                    try secPolicy.evaluate(response.serverTrust!, forHost: host)
+                    return .success(Void())
+                } catch {
+                    return .failure(error)
+                }
+            }
         }
 
         // Upload progress
@@ -371,8 +401,8 @@ public class RequestSerializer: NSObject {
                 }
             } else {
                 // For GET and others, encode as query parameters
-                if let dict = parameters as? [String: Any] {
-                    var components = URLComponents(url: request.url!, resolvingAgainstBaseURL: false)
+                if let dict = parameters as? [String: Any], let requestURL = request.url {
+                    var components = URLComponents(url: requestURL, resolvingAgainstBaseURL: false)
                     components?.queryItems = dict.map { URLQueryItem(name: $0.key, value: "\($0.value)") }
                     if let urlWithQuery = components?.url {
                         request.url = urlWithQuery

packages/https/platforms/ios/src/SecurityPolicyWrapper.swift

@@ -48,8 +48,17 @@ extension SecurityPolicyWrapper: ServerTrustEvaluating {
         }
 
         // Get the server certificates
-        let serverCertificates = (0..<SecTrustGetCertificateCount(trust)).compactMap { index -> SecCertificate? in
-            return SecTrustGetCertificateAtIndex(trust, index)
+        let serverCertificates: [SecCertificate]
+        if #available(iOS 15.0, *) {
+            if let certificateChain = SecTrustCopyCertificateChain(trust) as? [SecCertificate] {
+                serverCertificates = certificateChain
+            } else {
+                serverCertificates = []
+            }
+        } else {
+            serverCertificates = (0..<SecTrustGetCertificateCount(trust)).compactMap { index -> SecCertificate? in
+                return SecTrustGetCertificateAtIndex(trust, index)
+            }
         }
 
         // If no pinning mode, just validate the certificate chain