Skip to content

Commit c245fd4

Browse files
committed
Updated deprecated test functions
Updated Assert functions to non-deprecated equivalents.
1 parent f5d0fba commit c245fd4

File tree

2 files changed

+31
-29
lines changed

2 files changed

+31
-29
lines changed

Tests/HttpUnitTests/MediaTypeHeaderValueTest.cs

Lines changed: 25 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ internal class MediaTypeHeaderValueTests
1616
[TestMethod]
1717
public void Ctor_MediaTypeNull_Throw()
1818
{
19-
Assert.Throws(typeof(ArgumentException),
19+
Assert.ThrowsException(typeof(ArgumentException),
2020
() =>
2121
{
2222
new MediaTypeHeaderValue(null);
@@ -27,7 +27,7 @@ public void Ctor_MediaTypeNull_Throw()
2727
public void Ctor_MediaTypeEmpty_Throw()
2828
{
2929
// null and empty should be treated the same. So we also throw for empty strings.
30-
Assert.Throws(typeof(ArgumentException),
30+
Assert.ThrowsException(typeof(ArgumentException),
3131
() =>
3232
{
3333
new MediaTypeHeaderValue(string.Empty);
@@ -46,43 +46,45 @@ public void Ctor_MediaTypeInvalidFormat_ThrowFormatException()
4646
public void Ctor_MediaTypeValidFormat_SuccessfullyCreated()
4747
{
4848
MediaTypeHeaderValue mediaType = new MediaTypeHeaderValue("text/plain");
49-
Assert.Equal("text/plain", mediaType.MediaType);
50-
Assert.Null(mediaType.CharSet);
49+
Assert.AreEqual("text/plain", mediaType.MediaType);
50+
Assert.IsNull(mediaType.CharSet);
5151
}
5252

5353
[TestMethod]
5454
public void MediaType_SetAndGetMediaType_MatchExpectations()
5555
{
5656
MediaTypeHeaderValue mediaType = new MediaTypeHeaderValue("text/plain");
57-
Assert.Equal("text/plain", mediaType.MediaType);
57+
Assert.AreEqual("text/plain", mediaType.MediaType);
5858

5959
mediaType.MediaType = "application/xml";
60-
Assert.Equal("application/xml", mediaType.MediaType);
60+
Assert.AreEqual("application/xml", mediaType.MediaType);
6161
}
6262

6363
[TestMethod]
6464
public void CharSet_SetCharSetAndValidateObject_ParametersEntryForCharSetAdded()
6565
{
66-
MediaTypeHeaderValue mediaType = new MediaTypeHeaderValue("text/plain");
67-
mediaType.CharSet = "mycharset";
68-
Assert.Equal("mycharset", mediaType.CharSet);
66+
MediaTypeHeaderValue mediaType = new MediaTypeHeaderValue("text/plain")
67+
{
68+
CharSet = "mycharset"
69+
};
70+
Assert.AreEqual("mycharset", mediaType.CharSet);
6971

7072
mediaType.CharSet = null;
71-
Assert.Null(mediaType.CharSet);
73+
Assert.IsNull(mediaType.CharSet);
7274
mediaType.CharSet = null;
7375
}
7476

7577
[TestMethod]
7678
public void ToString_UseDifferentMediaTypes_AllSerializedCorrectly()
7779
{
7880
MediaTypeHeaderValue mediaType = new MediaTypeHeaderValue("text/plain");
79-
Assert.Equal("text/plain", mediaType.ToString());
81+
Assert.AreEqual("text/plain", mediaType.ToString());
8082

8183
mediaType.CharSet = "utf-8";
82-
Assert.Equal("text/plain; charset=utf-8", mediaType.ToString());
84+
Assert.AreEqual("text/plain; charset=utf-8", mediaType.ToString());
8385

8486
mediaType.CharSet = null;
85-
Assert.Equal("text/plain", mediaType.ToString());
87+
Assert.AreEqual("text/plain", mediaType.ToString());
8688
}
8789

8890
[TestMethod]
@@ -93,9 +95,9 @@ public void GetHashCode_UseMediaTypeWithoutParameters_SameOrDifferentHashCodes()
9395
mediaType2.CharSet = "utf-8";
9496
MediaTypeHeaderValue mediaType3 = new MediaTypeHeaderValue("text/plain");
9597

96-
Assert.NotEqual(mediaType1.GetHashCode(), mediaType2.GetHashCode());
97-
Assert.NotEqual(mediaType1.GetHashCode(), mediaType3.GetHashCode());
98-
Assert.NotEqual(mediaType2.GetHashCode(), mediaType3.GetHashCode());
98+
Assert.AreNotEqual(mediaType1.GetHashCode(), mediaType2.GetHashCode());
99+
Assert.AreNotEqual(mediaType1.GetHashCode(), mediaType3.GetHashCode());
100+
Assert.AreNotEqual(mediaType2.GetHashCode(), mediaType3.GetHashCode());
99101
}
100102

101103
[TestMethod]
@@ -106,10 +108,10 @@ public void Equals_UseMediaTypeWithoutParameters_EqualOrNotEqualNoExceptions()
106108
mediaType2.CharSet = "utf-8";
107109
MediaTypeHeaderValue mediaType7 = new MediaTypeHeaderValue("text/other");
108110

109-
Assert.False(mediaType1.Equals(mediaType2), "No params vs. charset.");
110-
Assert.False(mediaType2.Equals(mediaType1), "charset vs. no params.");
111-
Assert.False(mediaType1.Equals(null), "No params vs. <null>.");
112-
Assert.False(mediaType1.Equals(mediaType7), "text/plain vs. text/other.");
111+
Assert.IsFalse(mediaType1.Equals(mediaType2), "No params vs. charset.");
112+
Assert.IsFalse(mediaType2.Equals(mediaType1), "charset vs. no params.");
113+
Assert.IsFalse(mediaType1.Equals(null), "No params vs. <null>.");
114+
Assert.IsFalse(mediaType1.Equals(mediaType7), "text/plain vs. text/other.");
113115
}
114116

115117
[TestMethod]
@@ -144,7 +146,7 @@ public void Parse_SetOfInvalidValueStrings_Throws()
144146

145147
private static void AssertFormatException(string mediaType)
146148
{
147-
Assert.Throws(typeof(FormatException),
149+
Assert.ThrowsException(typeof(FormatException),
148150
() =>
149151
{
150152
new MediaTypeHeaderValue(mediaType);
@@ -156,12 +158,12 @@ private void CheckValidParse(
156158
MediaTypeHeaderValue expectedResult)
157159
{
158160
MediaTypeHeaderValue result = MediaTypeHeaderValue.Parse(input);
159-
Assert.Equal(expectedResult.ToString(), result.ToString());
161+
Assert.AreEqual(expectedResult.ToString(), result.ToString());
160162
}
161163

162164
private void CheckInvalidParse(string input, Type exceptionType)
163165
{
164-
Assert.Throws(exceptionType,
166+
Assert.ThrowsException(exceptionType,
165167
() =>
166168
{
167169
MediaTypeHeaderValue.Parse(input);

Tests/HttpUnitTests/StringContentTest.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public class StringContentTest
1818
[TestMethod]
1919
public void Ctor_NullString_ThrowsArgumentNullException()
2020
{
21-
Assert.Throws(typeof(ArgumentNullException),
21+
Assert.ThrowsException(typeof(ArgumentNullException),
2222
() => new StringContent(null));
2323
}
2424

@@ -28,7 +28,7 @@ public void Ctor_EmptyString_Accept()
2828
// Consider empty strings like null strings (null and empty strings should be treated equally).
2929
var content = new StringContent(string.Empty);
3030
Stream result = content.ReadAsStream();
31-
Assert.Equal(0, result.Length);
31+
Assert.AreEqual(0, result.Length);
3232
}
3333

3434
[TestMethod]
@@ -39,18 +39,18 @@ public void Ctor_DefineNoEncoding_DefaultEncodingUsed()
3939
Encoding defaultStringEncoding = Encoding.UTF8;
4040

4141
// If no encoding is defined, the default encoding is used: utf-8
42-
Assert.Equal("text/plain", content.Headers.ContentType.MediaType);
43-
Assert.Equal("utf-8", content.Headers.ContentType.CharSet);
42+
Assert.AreEqual("text/plain", content.Headers.ContentType.MediaType);
43+
Assert.AreEqual("utf-8", content.Headers.ContentType.CharSet);
4444

4545
// Make sure the default encoding is also used when serializing the content.
4646
var destination = new MemoryStream();
4747
content.CopyTo(destination);
4848

49-
Assert.Equal(8, destination.Length);
49+
Assert.AreEqual(8, destination.Length);
5050

5151
destination.Seek(0, SeekOrigin.Begin);
5252
string roundTrip = new StreamReader(destination).ReadToEnd();
53-
Assert.Equal(sourceString, roundTrip);
53+
Assert.AreEqual(sourceString, roundTrip);
5454
}
5555
}
5656
}

0 commit comments

Comments
 (0)