Fix config parsing bugs and unskip 3 passing tests

- Fix empty string parsing in version-overrides and ignores
- Fix line.strip() not being assigned in ignores parsing
- Fix test_resolve_dependencies_simple_file assertion
- Fix test_write_output_with_ignores to use read()
- Fix test_write_relative_constraints_path_different_dirs to include constraints

All tests now pass (177 passed, 4 skipped)

Author: jensens

CHANGES.md

@@ -4,6 +4,10 @@
 
 - Fix #65: Check source directories exist before writing to requirements-mxdev.txt. In **offline mode**: missing sources log WARNING and are written as comments (expected behavior). In **non-offline mode**: missing sources log ERROR and mxdev exits with RuntimeError (fatal error indicating checkout failure). This fixes mxmake two-stage installation workflow and prevents silent failures when sources fail to check out.
   [jensens]
+- Fix: Configuration parsing no longer logs "Can not parse override:" errors when `version-overrides` is empty. Empty lines in `version-overrides` and `ignores` are now properly skipped during parsing. Also fixed bug where `ignores` lines were not properly stripped of whitespace.
+  [jensens]
+- Fix: Three tests that were accidentally marked as skipped during PR #66 merge are now fixed and passing: `test_resolve_dependencies_simple_file` (fixed assertion to check line contents), `test_write_output_with_ignores` (fixed to use read() for proper ignore processing), and `test_write_relative_constraints_path_different_dirs` (fixed to include constraints content).
+  [jensens]
 - Fix: Add 'synchronize' event to pull_request workflow triggers. This ensures CI runs when PRs are updated with new commits (e.g., after rebasing or pushing new changes), not just when opened or reopened.
   [jensens]
 - Chore: Optimize GitHub Actions to prevent duplicate workflow runs on pull requests. Restrict `push` trigger to only run on `main` branch, so PRs only trigger via `pull_request` event. This reduces CI resource usage by 50% for PR workflows.

src/mxdev/config.py

@@ -71,6 +71,9 @@ def __init__(
         raw_overrides = settings.get("version-overrides", "").strip()
         self.overrides = {}
         for line in raw_overrides.split("\n"):
+            line = line.strip()
+            if not line:
+                continue
             try:
                 parsed = Requirement(line)
             except Exception:
@@ -81,7 +84,7 @@ def __init__(
         raw_ignores = settings.get("ignores", "").strip()
         self.ignore_keys = []
         for line in raw_ignores.split("\n"):
-            line.strip()
+            line = line.strip()
             if line:
                 self.ignore_keys.append(line)
 

tests/test_processing.py

@@ -125,7 +125,6 @@ def test_resolve_dependencies_missing_file(tmp_path):
     assert constraints == []
 
 
-@pytest.mark.skip(reason="Unrelated test from other branch - needs separate fix")
 def test_resolve_dependencies_simple_file(tmp_path):
     """Test resolve_dependencies with a simple requirements file."""
     from mxdev.processing import resolve_dependencies
@@ -143,8 +142,8 @@ def test_resolve_dependencies_simple_file(tmp_path):
             ignore_keys=[],
             variety="r",
         )
-        assert "requests>=2.28.0" in requirements
-        assert "urllib3==1.26.9" in requirements
+        assert any("requests>=2.28.0" in line for line in requirements)
+        assert any("urllib3==1.26.9" in line for line in requirements)
     finally:
         os.chdir(old_cwd)
 
@@ -512,13 +511,21 @@ def test_write_output_with_overrides(tmp_path):
         os.chdir(old_cwd)
 
 
-@pytest.mark.skip(reason="Unrelated test from other branch - needs separate fix")
 def test_write_output_with_ignores(tmp_path):
     """Test write() with ignores."""
     from mxdev.config import Configuration
+    from mxdev.processing import read
     from mxdev.processing import write
     from mxdev.state import State
 
+    # Create requirements.txt with packages
+    req_in = tmp_path / "requirements.txt"
+    req_in.write_text("requests\nmy.mainpackage==1.0.0\n-c constraints.txt\n")
+
+    # Create constraints.txt with packages
+    const_in = tmp_path / "constraints.txt"
+    const_in.write_text("urllib3==1.26.9\nmy.mainpackage==1.0.0\n")
+
     config_file = tmp_path / "mx.ini"
     config_file.write_text(
         """[settings]
@@ -532,13 +539,12 @@ def test_write_output_with_ignores(tmp_path):
 
     config = Configuration(str(config_file))
     state = State(configuration=config)
-    state.requirements = ["requests\n", "my.mainpackage==1.0.0\n"]
-    state.constraints = ["urllib3==1.26.9\n", "my.mainpackage==1.0.0\n"]
 
     old_cwd = os.getcwd()
     os.chdir(tmp_path)
 
     try:
+        read(state)
         write(state)
 
         req_file = tmp_path / "requirements-out.txt"
@@ -591,7 +597,6 @@ def test_write_output_with_main_package(tmp_path):
         os.chdir(old_cwd)
 
 
-@pytest.mark.skip(reason="Unrelated test from other branch - needs separate fix")
 def test_write_relative_constraints_path_different_dirs(tmp_path):
     """Test write() generates correct relative path for constraints file.
 
@@ -619,9 +624,13 @@ def test_write_relative_constraints_path_different_dirs(tmp_path):
 """
     )
 
-    # Create empty requirements.txt
+    # Create requirements.txt with a constraint reference
     req_in = tmp_path / "requirements.txt"
-    req_in.write_text("")
+    req_in.write_text("requests\n-c base-constraints.txt\n")
+
+    # Create base constraints file with some content
+    const_in = tmp_path / "base-constraints.txt"
+    const_in.write_text("urllib3==1.26.9\n")
 
     config = Configuration(str(config_file))
     state = State(configuration=config)
@@ -726,8 +735,6 @@ def test_write_dev_sources_missing_directories_raises_error(tmp_path, caplog):
     from mxdev.processing import write_dev_sources
     from mxdev.state import State
 
-    import pytest
-
     # Create config WITHOUT offline mode (non-offline mode)
     config_file = tmp_path / "mx.ini"
     config_file.write_text(