chore(Core) make code more efficient and thread-safe

Used ConfigureAwait(false) to free up the calling thread to do other work while the asynchronous operation is in progress, which can improve the overall throughput and concurrency of application

Author: mtokar3v

ReversoAPI.Web.Tests/Parsers/ConjugationResponseParserTest.cs

@@ -2,7 +2,6 @@
 using ReversoAPI.Web.Entities;
 using ReversoAPI.Web.Tools.Parsers;
 using ReversoAPI.Web.Values;
-using ReversoAPI.Web.Values.ConjugationObjects;
 using System.Collections.Generic;
 using System.IO;
 using System.Text;

ReversoAPI.Web/Builders/ConjugationParseBuilder.cs

@@ -2,7 +2,6 @@
 using ReversoAPI.Web.Entities;
 using ReversoAPI.Web.Exceptions;
 using ReversoAPI.Web.Values;
-using ReversoAPI.Web.Values.ConjugationObjects;
 using System;
 using System.Collections.Generic;
 using System.Linq;

ReversoAPI.Web/Clients/ConjugationClient.cs

@@ -42,7 +42,10 @@ public async Task<ConjugationData> GetAsync(string text, Language language)
 
             var url = CombineUrl(text, language);
 
-            using var response = await _apiConnector.GetAsync(url);
+            using var response = await _apiConnector
+                .GetAsync(url)
+                .ConfigureAwait(false);
+
             if (!response.IsHtml()) throw new FormatException("Response does not match html format");
 
             return _parser.Invoke(response.Content);

ReversoAPI.Web/Clients/ContextClient.cs

@@ -28,7 +28,10 @@ public async Task<ContextData> GetAsync(string text, Language source, Language t
 
             var url = CombineUrl(text, source, target);
 
-            using var response = await _apiConnector.GetAsync(url);
+            using var response = await _apiConnector
+                .GetAsync(url)
+                .ConfigureAwait(false);
+
             if (!response.IsHtml()) throw new FormatException("Response does not match html format");
 
             return _parser.Invoke(response.Content);

ReversoAPI.Web/Clients/PronunciationClient.cs

@@ -43,7 +43,10 @@ public async Task<Stream> GetAsync(string text, Language language, int speed = 1
             // TO DO: add text validation (length)
 
             var url = CombineUrl(text, language, speed);
-            var response = await _apiConnector.GetAsync(url);
+
+            var response = await _apiConnector
+                .GetAsync(url)
+                .ConfigureAwait(false);
 
             return response.Content;
         }

ReversoAPI.Web/Clients/SpellingClient.cs

@@ -31,7 +31,10 @@ public async Task<SpellingData> GetAsync(string text, Language language, Locale
             if (!_supportedLanguades.Contains(language)) throw new NotSupportedException($"'{language}' is not supported");
             // TO DO: Add locale validation
 
-            using var response = await _apiConnector.PostAsync(new Uri(SpellingURL), new SpellingRequest(text, language, locale));
+            using var response = await _apiConnector
+                .PostAsync(new Uri(SpellingURL), new SpellingRequest(text, language, locale))
+                .ConfigureAwait(false);
+
             var spellingDto = response.Content.Deserialize<SpellingResponse>();
 
             return spellingDto.ToModel();

ReversoAPI.Web/Clients/SynonymsClient.cs

@@ -28,7 +28,10 @@ public async Task<SynonymsData> GetAsync(string text, Language language)
 
             var url = CombineUrl(text, language);
 
-            using var response = await _apiConnector.GetAsync(url);
+            using var response = await _apiConnector
+                .GetAsync(url)
+                .ConfigureAwait(false);
+
             if (!response.IsHtml()) throw new FormatException("Response does not match html format");
 
             return _parser.Invoke(response.Content);

ReversoAPI.Web/Clients/TranslationClient.cs

@@ -22,7 +22,10 @@ public async Task<TranslationData> GetAsync(string text, Language source, Langua
             if (string.IsNullOrEmpty(text)) return null;
             if (source == target) throw new ArgumentException("Source and Target languages are similar"); // maybe should rid of this
 
-            using var response = await _apiConnector.PostAsync(new Uri(TranslationURL), new TranslationRequest(text, source, target));
+            using var response = await _apiConnector
+                .PostAsync(new Uri(TranslationURL), new TranslationRequest(text, source, target))
+                .ConfigureAwait(false);
+
             var translationDto = response.Content.Deserialize<TranslationResponse>();
 
             return translationDto.ToModel();

ReversoAPI.Web/Entities/ConjugationData.cs

@@ -1,5 +1,4 @@
 using ReversoAPI.Web.Values;
-using ReversoAPI.Web.Values.ConjugationObjects;
 using System.Collections.Generic;
 
 namespace ReversoAPI.Web.Entities

ReversoAPI.Web/Http/APIConnector.cs

@@ -43,15 +43,17 @@ public async Task<HttpResponse> GetAsync(Uri uri)
                 .Handle<HttpRequestException>()
                 .OrResult<HttpResponseMessage>(r => _httpStatusCodesWorthRetrying.Contains(r.StatusCode))
                 .WaitAndRetryAsync(RetryAttemptCount, attempt => TimeSpan.FromSeconds(Math.Pow(2, attempt)))
-                .ExecuteAsync(() => _httpClient.GetAsync(uri));
-
-            var content = await response.Content.ReadAsStreamAsync();
+                .ExecuteAsync(() => _httpClient.GetAsync(uri))
+                .ConfigureAwait(false);
 
+            var content = await response.Content
+                    .ReadAsStreamAsync()
+                    .ConfigureAwait(false);
 
             return new HttpResponse 
             { 
                 ContentType = response.Content.Headers.ContentType.MediaType,
-                Content = await MakeACopyAsync(content),
+                Content = await MakeACopyAsync(content).ConfigureAwait(false),
             };
         }
 
@@ -67,21 +69,24 @@ public async Task<HttpResponse> PostAsync(Uri uri, object payload)
                 .Handle<HttpRequestException>()
                 .OrResult<HttpResponseMessage>(r => _httpStatusCodesWorthRetrying.Contains(r.StatusCode))
                 .WaitAndRetryAsync(RetryAttemptCount, attempt => TimeSpan.FromSeconds(Math.Pow(2, attempt)))
-                .ExecuteAsync(() => _httpClient.PostAsync(uri, data));
+                .ExecuteAsync(() => _httpClient.PostAsync(uri, data))
+                .ConfigureAwait(false);
 
-            var content = await response.Content.ReadAsStreamAsync();
+            var content = await response.Content
+                .ReadAsStreamAsync()
+                .ConfigureAwait(false);
 
             return new HttpResponse 
             {
                 ContentType = response.Content.Headers.ContentType.MediaType,
-                Content = await MakeACopyAsync(content),
+                Content = await MakeACopyAsync(content).ConfigureAwait(false),
             };
         }
 
         private async Task<Stream> MakeACopyAsync(Stream stream)
         {
             var ms = new MemoryStream();
-            await stream.CopyToAsync(ms);
+            await stream.CopyToAsync(ms).ConfigureAwait(false);
             ms.Position = 0;
             return ms;
         }