Skip to content

Not returning the value that is documented #28

@yusufm

Description

@yusufm

legacy_timestamp: if true, use time.time() for timestamp instead of currentTime - startTime

The docstring states that if legacy_timestamp is set to True, then the value of time.time() is used. But in the code of the function (line 548), we see that actually the value is set to int(time.time()). This reduces the precision of the timestamp, since its being cast to int.

Also, if you remove the cast, it looks like there is some bad interaction with the packet data processing somewhere, where the value seems to be garbled.

Either we should actually use time.time(), which would provide much better precision, or change the documentation to reflect that we cast to int(), and also, why we do that.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions