Merge pull request #135 from pramukta/default_function_on_int_overflow

Default function on int overflow

Author: methane

msgpack/_packer.pyx

@@ -136,12 +136,20 @@ cdef class Packer(object):
             elif PyLong_Check(o):
                 # PyInt_Check(long) is True for Python 3.
                 # Sow we should test long before int.
-                if o > 0:
-                    ullval = o
-                    ret = msgpack_pack_unsigned_long_long(&self.pk, ullval)
-                else:
-                    llval = o
-                    ret = msgpack_pack_long_long(&self.pk, llval)
+                try:
+                    if o > 0:
+                        ullval = o
+                        ret = msgpack_pack_unsigned_long_long(&self.pk, ullval)
+                    else:
+                        llval = o
+                        ret = msgpack_pack_long_long(&self.pk, llval)
+                except OverflowError, oe:
+                    if not default_used and self._default is not None:
+                        o = self._default(o)
+                        default_used = True
+                        continue
+                    else:
+                        raise
             elif PyInt_Check(o):
                 longval = o
                 ret = msgpack_pack_long(&self.pk, longval)

msgpack/fallback.py

@@ -655,6 +655,10 @@ def _pack(self, obj, nest_limit=DEFAULT_RECURSE_LIMIT, isinstance=isinstance):
                     return self._buffer.write(struct.pack(">BQ", 0xcf, obj))
                 if -0x8000000000000000 <= obj < -0x80000000:
                     return self._buffer.write(struct.pack(">Bq", 0xd3, obj))
+                if not default_used and self._default is not None:
+                    obj = self._default(obj)
+                    default_used = True
+                    continue
                 raise PackValueError("Integer value out of range")
             if self._use_bin_type and isinstance(obj, bytes):
                 n = len(obj)

test/test_extension.py

@@ -55,3 +55,22 @@ def ext_hook(code, data):
     s = msgpack.packb(obj, default=default)
     obj2 = msgpack.unpackb(s, ext_hook=ext_hook)
     assert obj == obj2
+
+import sys
+if sys.version > '3':
+    long = int
+
+def test_overriding_hooks():
+    def default(obj):
+        if isinstance(obj, long):
+            return {"__type__": "long", "__data__": str(obj)}
+        else:
+            return obj
+
+    obj = {"testval": long(1823746192837461928374619)}
+    refobj = {"testval": default(obj["testval"])}
+    refout = msgpack.packb(refobj)
+    assert isinstance(refout, (str, bytes))
+    testout = msgpack.packb(obj, default=default)
+
+    assert refout == testout