Make TODO middleware configurable

Author: suhaibmujahid

bugbug/tools/code_review/agent.py

@@ -69,6 +69,7 @@ def __init__(
         show_patch_example: bool = False,
         verbose: bool = True,
         target_software: str = "Mozilla Firefox",
+        todo_enabled: bool = True,
     ) -> None:
         super().__init__()
 
@@ -99,19 +100,23 @@ def __init__(
 
         self._agent_model = llm
 
+        middleware = []
+        if todo_enabled:
+            middleware.append(
+                TodoListMiddleware(
+                    system_prompt=CODE_REVIEW_TODO_PROMPT,
+                    tool_description=CODE_REVIEW_TODO_TOOL_DESCRIPTION,
+                )
+            )
+
         self.agent = create_agent(
             llm,
             tools,
             system_prompt=SYSTEM_PROMPT_TEMPLATE.format(
                 target_software=self.target_software,
             ),
             response_format=ProviderStrategy(AgentResponse),
-            middleware=[
-                TodoListMiddleware(
-                    system_prompt=CODE_REVIEW_TODO_PROMPT,
-                    tool_description=CODE_REVIEW_TODO_TOOL_DESCRIPTION,
-                )
-            ],
+            middleware=middleware,
         )
 
         self.review_comments_db = review_comments_db

notebooks/code_review_evaluation.ipynb

@@ -69,9 +69,11 @@
     "class CodeReviewModel(weave.Model):\n",
     "    \"\"\"Weave Model wrapper for CodeReviewTool.\"\"\"\n",
     "\n",
+    "    todo_enabled: bool\n",
+    "\n",
     "    @cached_property\n",
     "    def tool(self):\n",
-    "        return CodeReviewTool.create()\n",
+    "        return CodeReviewTool.create(todo_enabled=self.todo_enabled)\n",
     "\n",
     "    @weave.op()\n",
     "    async def invoke(self, diff_id: int, patch_summary: str) -> dict:\n",
@@ -82,7 +84,7 @@
     "        }\n",
     "\n",
     "\n",
-    "model = CodeReviewModel()"
+    "model = CodeReviewModel(todo_enabled=True)"
    ]
   },
   {

services/reviewhelper-api/app/config.py

@@ -35,6 +35,9 @@ class Settings(BaseSettings):
     # Cloud Run
     port: int = 8080
 
+    # Agent settings
+    todo_enabled: bool = True
+
     model_config = {
         "env_file": ".env",
         "env_file_encoding": "utf-8",

services/reviewhelper-api/app/review_processor.py

@@ -4,6 +4,7 @@
 from functools import cache
 from typing import Collection, Iterable
 
+from app.config import settings
 from app.database.models import GeneratedComment, ReviewRequest
 from app.enums import Platform
 from bugbug.tools.core.exceptions import LargeDiffError
@@ -32,7 +33,7 @@ class RevisionNotYetPublicError(Exception):
 def get_code_review_tool():
     from bugbug.tools.code_review import CodeReviewTool
 
-    return CodeReviewTool.create()
+    return CodeReviewTool.create(todo_enabled=settings.todo_enabled)
 
 
 async def process_review(