CSHARP-5405: Remove the BSON document size validation requirement for the client bulk write operation (#1561)

Author: sanych-sun

src/MongoDB.Driver/Core/WireProtocol/Messages/Encoders/BinaryEncoders/ClientBulkWriteOpsSectionFormatter.cs

@@ -74,7 +74,7 @@ public void FormatSection(ClientBulkWriteOpsCommandMessageSection section, IBson
 
             var batch = section.Documents;
             var maxDocumentSize = section.MaxDocumentSize ?? binaryWriter.Settings.MaxDocumentSize;
-            binaryWriter.PushSettings(s => ((BsonBinaryWriterSettings)s).MaxDocumentSize = maxDocumentSize);
+            binaryWriter.PushSettings(s => ((BsonBinaryWriterSettings)s).MaxDocumentSize = int.MaxValue);
             binaryWriter.PushElementNameValidator(NoOpElementNameValidator.Instance);
             _nsInfoWriter.PushSettings(s => ((BsonBinaryWriterSettings)s).MaxDocumentSize = maxDocumentSize);
             try
@@ -98,6 +98,12 @@ public void FormatSection(ClientBulkWriteOpsCommandMessageSection section, IBson
                         break;
                     }
                 }
+
+                if (processedCount == 0)
+                {
+                    throw new FormatException("Cannot send empty batch.");
+                }
+
                 batch.SetProcessedCount(processedCount);
                 stream.BackpatchSize(startPosition);
 

tests/MongoDB.Driver.Tests/Specifications/crud/prose-tests/CrudProseTests.cs

@@ -27,8 +27,6 @@
 using MongoDB.Driver.Core.TestHelpers;
 using MongoDB.Driver.Core.TestHelpers.Logging;
 using MongoDB.Driver.Core.TestHelpers.XunitExtensions;
-using MongoDB.Driver.Encryption;
-using MongoDB.Driver.TestHelpers;
 using MongoDB.TestHelpers.XunitExtensions;
 using Xunit;
 using Xunit.Abstractions;
@@ -410,36 +408,6 @@ public async Task MongoClient_bulkWrite_handles_getMore_error([Values(true, fals
             eventCapturer.Events.Should().Contain(e => ((CommandStartedEvent)e).CommandName == "killCursors");
         }
 
-        // https://github.com/mongodb/specifications/blob/7517681e6a3186cb7f3114314a9fe1bc3a747b9f/source/crud/tests/README.md?plain=1#L371
-        [Theory]
-        [ParameterAttributeData]
-        internal async Task MongoClient_bulkWrite_returns_error_for_unacknowledged_too_large_insert(
-            [Values(true, false)] bool async,
-            [Values(true, false)] bool isReplace)
-        {
-            RequireServer.Check().Supports(Feature.ClientBulkWrite).Serverless(false);
-            var maxDocumentSize = DriverTestConfiguration.GetConnectionDescription().MaxDocumentSize;
-
-            var document = new BsonDocument() { { "a", new string('b', maxDocumentSize) } };
-            BulkWriteModel[] models = isReplace
-                    ? new[] { new BulkWriteReplaceOneModel<BsonDocument>("db.coll", Builders<BsonDocument>.Filter.Empty, document) }
-                    : new[] { new BulkWriteInsertOneModel<BsonDocument>("db.coll", document) };
-
-            using var client = CreateMongoClient(null);
-            var bulkWriteOptions = new ClientBulkWriteOptions
-            {
-                WriteConcern = WriteConcern.Unacknowledged,
-                IsOrdered = false
-            };
-
-            var exception = async
-                ? await Record.ExceptionAsync(() => client.BulkWriteAsync(models, bulkWriteOptions))
-                : Record.Exception(() => client.BulkWrite(models, bulkWriteOptions));
-
-            var bulkWriteException = exception.Should().BeOfType<ClientBulkWriteException>().Subject;
-            bulkWriteException.InnerException.Should().BeOfType<FormatException>();
-        }
-
         // https://github.com/mongodb/specifications/blob/7517681e6a3186cb7f3114314a9fe1bc3a747b9f/source/crud/tests/README.md?plain=1#L422
         //
         // This test is commented out because calculations in spec does not include "$db" and "lsid" fields of bulkWrite command.