Add Python quality checks to CI workflow

Author: davidsteiner

.github/workflows/ci.yml

@@ -7,6 +7,27 @@ on:
     branches: [ "main" ]
 
 jobs:
+  python-quality-checks:
+    name: Python quality checks
+    runs-on: ubuntu-latest
+    timeout-minutes: 5
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Install poetry
+        run: pipx install poetry==1.8.2
+      - name: Setup Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.11'
+      - name: Install dependencies
+        run: poetry install
+      - name: Lint
+        run: poetry run ruff check .
+      - name: Check formatting
+        run: poetry run ruff format --check .
+      - name: Type checking
+        run: poetry run mypy infrastructure
   rust-quality-checks:
     name: Rust quality checks
     runs-on: ubuntu-latest

infrastructure/app.py

@@ -1,6 +1,5 @@
 #!/usr/bin/env python3
 import aws_cdk as cdk
-
 from stack.stack import ServerlessRustStack
 
 app = cdk.App()

infrastructure/stack/stack.py

@@ -1,15 +1,15 @@
 import pathlib
 
 from aws_cdk import CfnOutput, Stack
-from aws_cdk.aws_lambda import Architecture, Code, Function, Runtime
 from aws_cdk.aws_cognito import (
-    UserPool,
-    StandardAttributes,
-    StandardAttribute,
     AuthFlow,
+    StandardAttribute,
+    StandardAttributes,
+    UserPool,
     UserPoolClient,
 )
-from aws_cdk.aws_dynamodb import Table, Attribute, AttributeType
+from aws_cdk.aws_dynamodb import Attribute, AttributeType, Table
+from aws_cdk.aws_lambda import Architecture, Code, Function, Runtime
 from constructs import Construct
 
 from stack.api import ServerlessApi

pyproject.toml

@@ -40,12 +40,13 @@ exclude = [
 
 [tool.ruff.lint]
 select = [
+    "B", # flake8-bugbear
+    "C", # flake8-comprehensions
     "E", # pycodestyle errors
-    "W", # pycodestyle warnings
     "F", # pyflakes
-    "C", # flake8-comprehensions
-    "B", # flake8-bugbear
+    "I", # imports
     "N", # PEP 8 naming convention
+    "W", # pycodestyle warnings
 ]
 
 ignore = [

src/settings.rs

@@ -2,6 +2,5 @@ use serde::Deserialize;
 
 #[derive(Debug, Deserialize)]
 pub struct Settings {
-    #[serde(default)]
     pub table_name: String,
 }