From d3c1c4bf3d993ed9fb19804ada585671afe3dafd Mon Sep 17 00:00:00 2001
From: tdgao <mr.trumgao@gmail.com>
Date: Thu, 4 Jun 2026 22:22:20 -0600
Subject: [PATCH] fix: malformed versions causing versions list page to crash

---
 apps/frontend/src/pages/[type]/[project].vue  | 14 +++++++----
 .../src/pages/[type]/[project]/changelog.vue  | 23 ++++++++++++++-----
 .../[type]/[project]/settings/versions.vue    | 10 +++++---
 .../src/pages/[type]/[project]/versions.vue   | 14 +++++++----
 .../ui/src/components/base/Pagination.vue     |  1 -
 .../project/ProjectPageVersions.vue           | 17 ++++++++++----
 .../version/VersionFilterControl.vue          | 10 ++++----
 7 files changed, 61 insertions(+), 28 deletions(-)

diff --git a/apps/frontend/src/pages/[type]/[project].vue b/apps/frontend/src/pages/[type]/[project].vue
index b338886525..cc8a514956 100644
--- a/apps/frontend/src/pages/[type]/[project].vue
+++ b/apps/frontend/src/pages/[type]/[project].vue
@@ -1874,12 +1874,18 @@ const isSettings = computed(() => route.name.startsWith('type-project-settings')
 
 // Transform versionsV3 to be same shape as versionsV2 for compatibility in project pages
 const versionsRaw = computed(() => {
-	return (versionsV3.value ?? []).map((v) => {
-		const isModpack = v.project_types?.includes('modpack')
+	return (versionsV3.value ?? []).map((version) => {
+		const files = Array.isArray(version.files) ? version.files : []
+		const gameVersions = Array.isArray(version.game_versions) ? version.game_versions : []
+		const loaders = Array.isArray(version.loaders) ? version.loaders : []
+		const isModpack = version.project_types?.includes('modpack')
+		const mrpackLoaders = Array.isArray(version.mrpack_loaders) ? version.mrpack_loaders : []
 
 		return {
-			...v,
-			loaders: isModpack && v.mrpack_loaders ? v.mrpack_loaders : v.loaders,
+			...version,
+			files,
+			game_versions: gameVersions,
+			loaders: isModpack && mrpackLoaders.length ? mrpackLoaders : loaders,
 		}
 	})
 })
diff --git a/apps/frontend/src/pages/[type]/[project]/changelog.vue b/apps/frontend/src/pages/[type]/[project]/changelog.vue
index cd85b5cac2..f48956653a 100644
--- a/apps/frontend/src/pages/[type]/[project]/changelog.vue
+++ b/apps/frontend/src/pages/[type]/[project]/changelog.vue
@@ -53,11 +53,11 @@
 										{{ formatDate(version.date_published) }}</span
 									>
 								</div>
-								<ButtonStyled color="brand" type="transparent">
+								<ButtonStyled v-if="getPrimaryFile(version)" color="brand" type="transparent">
 									<a
 										class="ml-auto"
 										:href="createDownloadUrl(version)"
-										:download="getPrimaryFile(version).filename"
+										:download="getPrimaryFile(version)?.filename"
 										:title="`Download ${version.name}`"
 									>
 										<DownloadIcon aria-hidden="true" />
@@ -145,10 +145,10 @@ const filteredVersions = computed(() => {
 		(projectVersion) =>
 			(selectedGameVersions.length === 0 ||
 				selectedGameVersions.some((gameVersion) =>
-					projectVersion.game_versions.includes(gameVersion),
+					getVersionGameVersions(projectVersion).includes(gameVersion),
 				)) &&
 			(selectedLoaders.length === 0 ||
-				selectedLoaders.some((loader) => projectVersion.loaders.includes(loader))) &&
+				selectedLoaders.some((loader) => getVersionLoaders(projectVersion).includes(loader))) &&
 			(selectedVersionTypes.length === 0 ||
 				selectedVersionTypes.includes(projectVersion.version_type)),
 	)
@@ -233,14 +233,25 @@ watch(
 )
 
 function getPrimaryFile(version) {
-	return version.files.find((x) => x.primary) || version.files[0]
+	return version.files?.find((x) => x.primary) || version.files?.[0]
 }
 
 function createDownloadUrl(version) {
-	return createProjectDownloadUrl(getPrimaryFile(version).url, {
+	const file = getPrimaryFile(version)
+	if (!file?.url) return undefined
+
+	return createProjectDownloadUrl(file.url, {
 		reason: cdnDownloadReason.value,
 	})
 }
+
+function getVersionGameVersions(version) {
+	return Array.isArray(version.game_versions) ? version.game_versions : []
+}
+
+function getVersionLoaders(version) {
+	return Array.isArray(version.loaders) ? version.loaders : []
+}
 </script>
 
 <style lang="scss">
diff --git a/apps/frontend/src/pages/[type]/[project]/settings/versions.vue b/apps/frontend/src/pages/[type]/[project]/settings/versions.vue
index 4d1e11ebca..25b29c2e5d 100644
--- a/apps/frontend/src/pages/[type]/[project]/settings/versions.vue
+++ b/apps/frontend/src/pages/[type]/[project]/settings/versions.vue
@@ -111,10 +111,11 @@
 								color: 'primary',
 								hoverFilled: true,
 								link: createDownloadUrl(version),
-								download: getPrimaryFile(version).filename,
+								download: getPrimaryFile(version)?.filename,
 								action: () => {
 									emit('onDownload')
 								},
+								shown: !!getPrimaryFile(version),
 							},
 							{
 								id: 'new-tab',
@@ -402,7 +403,7 @@ const emit = defineEmits(['onDownload'])
 const baseDropdownId = useId()
 
 function getPrimaryFile(version: Labrinth.Versions.v3.Version) {
-	return version.files.find((x) => x.primary) || version.files[0]
+	return version.files?.find((x) => x.primary) || version.files?.[0]
 }
 
 watch(
@@ -417,7 +418,10 @@ watch(
 )
 
 function createDownloadUrl(version: Labrinth.Versions.v3.Version) {
-	return createProjectDownloadUrl(getPrimaryFile(version).url, {
+	const file = getPrimaryFile(version)
+	if (!file?.url) return undefined
+
+	return createProjectDownloadUrl(file.url, {
 		reason: cdnDownloadReason.value,
 	})
 }
diff --git a/apps/frontend/src/pages/[type]/[project]/versions.vue b/apps/frontend/src/pages/[type]/[project]/versions.vue
index 75996265aa..38a93096cf 100644
--- a/apps/frontend/src/pages/[type]/[project]/versions.vue
+++ b/apps/frontend/src/pages/[type]/[project]/versions.vue
@@ -43,11 +43,11 @@
 				:open-modal="currentMember ? () => handleOpenCreateVersionModal() : undefined"
 			>
 				<template #actions="{ version }">
-					<ButtonStyled circular type="transparent">
+					<ButtonStyled v-if="getPrimaryFile(version)" circular type="transparent">
 						<a
 							v-tooltip="`Download`"
 							:href="createDownloadUrl(version)"
-							:download="getPrimaryFile(version).filename"
+							:download="getPrimaryFile(version)?.filename"
 							class="hover:!bg-button-bg [&>svg]:!text-green"
 							aria-label="Download"
 							@click="emit('onDownload')"
@@ -102,10 +102,11 @@
 									color: 'primary',
 									hoverFilled: true,
 									link: createDownloadUrl(version),
-									download: getPrimaryFile(version).filename,
+									download: getPrimaryFile(version)?.filename,
 									action: () => {
 										emit('onDownload')
 									},
+									shown: !!getPrimaryFile(version),
 								},
 								{
 									id: 'new-tab',
@@ -318,7 +319,7 @@ const emit = defineEmits(['onDownload', 'deleteVersion'])
 const baseDropdownId = useId()
 
 function getPrimaryFile(version) {
-	return version.files.find((x) => x.primary) || version.files[0]
+	return version.files?.find((x) => x.primary) || version.files?.[0]
 }
 
 watch(
@@ -333,7 +334,10 @@ watch(
 )
 
 function createDownloadUrl(version) {
-	return createProjectDownloadUrl(getPrimaryFile(version).url, {
+	const file = getPrimaryFile(version)
+	if (!file?.url) return undefined
+
+	return createProjectDownloadUrl(file.url, {
 		reason: cdnDownloadReason.value,
 	})
 }
diff --git a/packages/ui/src/components/base/Pagination.vue b/packages/ui/src/components/base/Pagination.vue
index e356196f92..ba1eae2cda 100644
--- a/packages/ui/src/components/base/Pagination.vue
+++ b/packages/ui/src/components/base/Pagination.vue
@@ -83,7 +83,6 @@ const props = withDefaults(
 	{
 		page: 1,
 		count: 1,
-		linkFunction: (page: number) => void page,
 	},
 )
 
diff --git a/packages/ui/src/components/project/ProjectPageVersions.vue b/packages/ui/src/components/project/ProjectPageVersions.vue
index 5b5131d390..a2a8f3208b 100644
--- a/packages/ui/src/components/project/ProjectPageVersions.vue
+++ b/packages/ui/src/components/project/ProjectPageVersions.vue
@@ -327,15 +327,22 @@ const props = withDefaults(
 )
 
 function getModpackLoaders(version: VersionWithDisplayUrlEnding): string[] {
+	const loaders = Array.isArray(version.loaders) ? version.loaders : []
+
 	if (props.project.project_type !== 'modpack') {
-		return version.loaders
+		return loaders
 	}
 
-	if (version.mrpack_loaders?.length) {
-		return version.mrpack_loaders
+	const mrpackLoaders = Array.isArray(version.mrpack_loaders) ? version.mrpack_loaders : []
+	if (mrpackLoaders.length) {
+		return mrpackLoaders
 	}
 
-	return version.loaders.filter((loader) => loader !== 'mrpack')
+	return loaders.filter((loader) => loader !== 'mrpack')
+}
+
+function getGameVersions(version: VersionWithDisplayUrlEnding): string[] {
+	return Array.isArray(version.game_versions) ? version.game_versions : []
 }
 
 function hasNoModLoader(loaders: string[]): boolean {
@@ -350,10 +357,12 @@ function hasNoModLoader(loaders: string[]): boolean {
 const normalizedVersions = computed<DisplayVersion[]>(() =>
 	props.versions.map((version) => {
 		const loaders = getModpackLoaders(version)
+		const gameVersions = getGameVersions(version)
 		const noModLoader = hasNoModLoader(loaders)
 
 		return {
 			...version,
+			game_versions: gameVersions,
 			loaders: noModLoader ? [] : loaders,
 			noModLoader,
 		}
diff --git a/packages/ui/src/components/version/VersionFilterControl.vue b/packages/ui/src/components/version/VersionFilterControl.vue
index 01c21b2ffc..c463aad65b 100644
--- a/packages/ui/src/components/version/VersionFilterControl.vue
+++ b/packages/ui/src/components/version/VersionFilterControl.vue
@@ -109,15 +109,15 @@ const filterOptions = computed(() => {
 		platform: [],
 	}
 
-	const platformSet = new Set()
-	const gameVersionSet = new Set()
-	const channelSet = new Set()
+	const platformSet = new Set<Filter>()
+	const gameVersionSet = new Set<Filter>()
+	const channelSet = new Set<Filter>()
 
 	for (const version of props.versions) {
-		for (const loader of version.loaders) {
+		for (const loader of Array.isArray(version.loaders) ? version.loaders : []) {
 			platformSet.add(loader)
 		}
-		for (const gameVersion of version.game_versions) {
+		for (const gameVersion of Array.isArray(version.game_versions) ? version.game_versions : []) {
 			gameVersionSet.add(gameVersion)
 		}
 		channelSet.add(version.version_type)