From 33c4c0acd7c1997abb07002bc617eb8970839fac Mon Sep 17 00:00:00 2001 From: tdgao Date: Wed, 3 Jun 2026 12:21:42 -0600 Subject: [PATCH 1/2] fix: incorrectly showing empty state for versions page --- apps/frontend/src/pages/[type]/[project].vue | 2 ++ apps/frontend/src/pages/[type]/[project]/versions.vue | 10 +++++++++- packages/ui/src/providers/project-page.ts | 1 + 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/apps/frontend/src/pages/[type]/[project].vue b/apps/frontend/src/pages/[type]/[project].vue index b338886525..c545117433 100644 --- a/apps/frontend/src/pages/[type]/[project].vue +++ b/apps/frontend/src/pages/[type]/[project].vue @@ -1892,6 +1892,7 @@ const versions = computed(() => { // Versions loading state const versionsLoading = computed(() => versionsV3Loading.value) +const versionsLoaded = computed(() => versionsV3.value !== undefined || !!_versionsV3Error.value) // Load versions on demand (client-side only) function loadVersions() { @@ -2735,6 +2736,7 @@ provideProjectPageContext({ // Lazy version loading versions, versionsLoading, + versionsLoaded, // Lazy dependencies loading dependencies, dependenciesLoading: computed(() => dependenciesLoading.value), diff --git a/apps/frontend/src/pages/[type]/[project]/versions.vue b/apps/frontend/src/pages/[type]/[project]/versions.vue index 75996265aa..128cd91466 100644 --- a/apps/frontend/src/pages/[type]/[project]/versions.vue +++ b/apps/frontend/src/pages/[type]/[project]/versions.vue @@ -2,7 +2,7 @@
@@ -290,10 +290,18 @@ const { invalidate, versions, versionsLoading, + versionsLoaded, loadVersions, cdnDownloadReason, } = injectProjectPageContext() +const showVersionsLoadingState = computed( + () => + !versions.value?.length && + (versionsLoading.value || + (!versionsLoaded.value && (project.value?.versions?.length ?? 0) > 0)), +) + // Load versions on mount (client-side) onMounted(() => { loadVersions() diff --git a/packages/ui/src/providers/project-page.ts b/packages/ui/src/providers/project-page.ts index 4323c2521d..11a6ecdbae 100644 --- a/packages/ui/src/providers/project-page.ts +++ b/packages/ui/src/providers/project-page.ts @@ -17,6 +17,7 @@ export interface ProjectPageContext { // Lazy version loading (client-side only) versions: Ref versionsLoading: Ref + versionsLoaded: Ref // Lazy dependencies loading (client-side only) dependencies: Ref dependenciesLoading: Ref From b8a235f85ae757aae1c788a8ab0db5d316e17aa7 Mon Sep 17 00:00:00 2001 From: tdgao Date: Thu, 4 Jun 2026 21:44:03 -0600 Subject: [PATCH 2/2] refactor: pnpm prepr --- apps/frontend/src/pages/[type]/[project]/versions.vue | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/apps/frontend/src/pages/[type]/[project]/versions.vue b/apps/frontend/src/pages/[type]/[project]/versions.vue index 128cd91466..54f9c6add7 100644 --- a/apps/frontend/src/pages/[type]/[project]/versions.vue +++ b/apps/frontend/src/pages/[type]/[project]/versions.vue @@ -1,10 +1,7 @@