Skip to content

Commit 7dbbf22

Browse files
fix: move pragma no cover to defensive else branch
ROOT CAUSE: strict-no-cover was failing because pragma was on the if statement which IS covered. The uncovered branch is the else case. CHANGES: - Moved pragma from if statement to else branch (continue statement) - Added comment explaining why this is defensive code IMPACT: - strict-no-cover will now pass - Tests remain fully functional - Defensive code properly marked Refs: #2086
1 parent 00cca01 commit 7dbbf22

File tree

1 file changed

+4
-1
lines changed
  • src/mcp/server/mcpserver/tools

1 file changed

+4
-1
lines changed

src/mcp/server/mcpserver/tools/base.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,11 @@ async def run(
125125

126126
deps = find_dependency_parameters(self.fn)
127127
for dep_name in self.dependency_kwarg_names:
128-
if dep_name in deps: # pragma: no cover (defensive, should always be in deps)
128+
if dep_name in deps:
129129
direct_args[dep_name] = await dependency_resolver.resolve(dep_name, deps[dep_name])
130+
else:
131+
# Defensive: should never happen since dependency_kwarg_names is built from deps
132+
continue # pragma: no cover
130133

131134
result = await self.fn_metadata.call_fn_with_arg_validation(
132135
self.fn,

0 commit comments

Comments
 (0)