Merge branch 'main' into fix/547-dispose-on-error

Author: phanikpemmaraju

README.md

@@ -47,13 +47,141 @@ Please follow the [Contributing Guidelines](CONTRIBUTING.md).
 
 - Christian Tzolov
 - Dariusz Jędrzejczyk
+- Daniel Garnier-Moiroux
 
 ## Links
 
 - [GitHub Repository](https://github.com/modelcontextprotocol/java-sdk)
 - [Issue Tracker](https://github.com/modelcontextprotocol/java-sdk/issues)
 - [CI/CD](https://github.com/modelcontextprotocol/java-sdk/actions)
 
+## Architecture and Design Decisions
+
+### Introduction
+
+Building a general-purpose MCP Java SDK requires making technology decisions in areas where the JDK provides limited or no support. The Java ecosystem is powerful but fragmented: multiple valid approaches exist, each with strong communities.
+Our goal is not to prescribe "the one true way," but to provide a reference implementation of the MCP specification that is:
+
+* **Pragmatic** – makes developers productive quickly
+* **Interoperable** – aligns with widely used libraries and practices
+* **Pluggable** – allows alternatives where projects prefer different stacks
+* **Grounded in team familiarity** – we chose technologies the team can be productive with today, while remaining open to community contributions that broaden the SDK
+
+### Key Choices and Considerations
+
+The SDK had to make decisions in the following areas:
+
+1. **JSON serialization** – mapping between JSON and Java types
+
+2. **Programming model** – supporting asynchronous processing, cancellation, and streaming while staying simple for blocking use cases
+
+3. **Observability** – logging and enabling integration with metrics/tracing
+
+4. **Remote clients and servers** – supporting both consuming MCP servers (client transport) and exposing MCP endpoints (server transport with authorization)
+
+The following sections explain what we chose, why it made sense, and how the choices align with the SDK's goals.
+
+### 1. JSON Serialization
+
+* **SDK Choice**: Jackson for JSON serialization and deserialization, behind an SDK abstraction (`mcp-json`)
+
+* **Why**: Jackson is widely adopted across the Java ecosystem, provides strong performance and a mature annotation model, and is familiar to the SDK team and many potential contributors.
+
+* **How we expose it**: Public APIs use a zero-dependency abstraction (`mcp-json`). Jackson is shipped as the default implementation (`mcp-jackson2`), but alternatives can be plugged in.
+
+* **How it fits the SDK**: This offers a pragmatic default while keeping flexibility for projects that prefer different JSON libraries.
+
+### 2. Programming Model
+
+* **SDK Choice**: Reactive Streams for public APIs, with Project Reactor as the internal implementation and a synchronous facade for blocking use cases
+
+* **Why**: MCP builds on JSON-RPC's asynchronous nature and defines a bidirectional protocol on top of it, enabling asynchronous and streaming interactions. MCP explicitly supports:
+
+    * Multiple in-flight requests and responses
+    * Notifications that do not expect a reply
+    * STDIO transports for inter-process communication using pipes
+    * Streaming transports such as Server-Sent Events and Streamable HTTP
+
+    These requirements call for a programming model more powerful than single-result futures like `CompletableFuture`.
+
+    * **Reactive Streams: the Community Standard**
+
+        Reactive Streams is a small Java specification that standardizes asynchronous stream processing with backpressure. It defines four minimal interfaces (Publisher, Subscriber, Subscription, and Processor). These interfaces are widely recognized as the standard contract for async, non-blocking pipelines in Java.
+
+    * **Reactive Streams Implementation**
+
+        The SDK uses Project Reactor as its implementation of the Reactive Streams specification. Reactor is mature, widely adopted, provides rich operators, and integrates well with observability through context propagation. Team familiarity also allowed us to deliver a solid foundation quickly.
+        We plan to convert the public API to only expose Reactive Streams interfaces. By defining the public API in terms of Reactive Streams interfaces and using Reactor internally, the SDK stays standards-based while benefiting from a practical, production-ready implementation.
+
+    * **Synchronous Facade in the SDK**
+
+        Not all MCP use cases require streaming pipelines. Many scenarios are as simple as "send a request and block until I get the result."
+        To support this, the SDK provides a synchronous facade layered on top of the reactive core. Developers can stay in a blocking model when it's enough, while still having access to asynchronous streaming when needed.
+
+* **How it fits the SDK**: This design balances scalability, approachability, and future evolution such as Virtual Threads and Structured Concurrency in upcoming JDKs.
+
+### 3. Observability
+
+* **SDK Choice**: SLF4J for logging; Reactor Context for observability propagation
+
+* **Why**: SLF4J is the de facto logging facade in Java, with broad compatibility. Reactor Context enables propagation of observability data such as correlation IDs and tracing state across async boundaries. This ensures interoperability with modern observability frameworks.
+
+* **How we expose it**: Public APIs log through SLF4J only, with no backend included. Observability metadata flows through Reactor pipelines. The SDK itself does not ship metrics or tracing implementations.
+
+* **How it fits the SDK**: This provides reliable logging by default and seamless integration with Micrometer, OpenTelemetry, or similar systems for metrics and tracing.
+
+### 4. Remote MCP Clients and Servers
+
+MCP supports both clients (applications consuming MCP servers) and servers (applications exposing MCP endpoints). The SDK provides support for both sides.
+
+#### Client Transport in the SDK
+
+* **SDK Choice**: JDK HttpClient (Java 11+) as the default client, with optional Spring WebClient support
+
+* **Why**: The JDK HttpClient is built-in, portable, and supports streaming responses. This keeps the default lightweight with no extra dependencies. Spring WebClient support is available for Spring-based projects.
+
+* **How we expose it**: MCP Client APIs are transport-agnostic. The core module ships with JDK HttpClient transport. A Spring module provides WebClient integration.
+
+* **How it fits the SDK**: This ensures all applications can talk to MCP servers out of the box, while allowing richer integration in Spring and other environments.
+
+#### Server Transport in the SDK
+
+* **SDK Choice**: Jakarta Servlet implementation in core, with optional Spring WebFlux and Spring WebMVC providers
+
+* **Why**: Servlet is the most widely deployed Java server API. WebFlux and WebMVC cover a significant part of the Spring community. Together these provide reach across blocking and non-blocking models.
+
+* **How we expose it**: Server APIs are transport-agnostic. Core includes Servlet support. Spring modules extend support for WebFlux and WebMVC.
+
+* **How it fits the SDK**: This allows developers to expose MCP servers in the most common Java environments today, while enabling other transport implementations such as Netty, Vert.x, or Helidon.
+
+#### Authorization in the SDK
+
+* **SDK Choice**: Pluggable authorization hooks for MCP servers; no built-in implementation
+
+* **Why**: MCP servers must restrict access to authenticated and authorized clients. Authorization needs differ across environments such as Spring Security, MicroProfile JWT, or custom solutions. Providing hooks avoids lock-in and leverages proven libraries.
+
+* **How we expose it**: Authorization is integrated into the server transport layer. The SDK does not include its own authorization system.
+
+* **How it fits the SDK**: This keeps server-side security ecosystem-neutral, while ensuring applications can plug in their preferred authorization strategy.
+
+### Project Structure of the SDK
+
+The SDK is organized into modules to separate concerns and allow adopters to bring in only what they need:
+* `mcp-bom` – Dependency versions
+* `mcp-core` – Reference implementation (STDIO, JDK HttpClient, Servlet)
+* `mcp-json` – JSON abstraction
+* `mcp-jackson2` – Jackson implementation of JSON binding
+* `mcp` – Convenience bundle (core + Jackson)
+* `mcp-test` – Shared testing utilities
+* `mcp-spring` – Spring integrations (WebClient, WebFlux, WebMVC)
+
+For example, a minimal adopter may depend only on `mcp` (core + Jackson), while a Spring-based application can use `mcp-spring` for deeper framework integration.
+
+### Future Directions
+
+The SDK is designed to evolve with the Java ecosystem. Areas we are actively watching include:
+Concurrency in the JDK – Virtual Threads and Structured Concurrency may simplify the synchronous API story
+
 ## License
 
 This project is licensed under the [MIT License](LICENSE).

mcp-bom/pom.xml

@@ -7,7 +7,7 @@
     <parent>
         <groupId>io.modelcontextprotocol.sdk</groupId>
         <artifactId>mcp-parent</artifactId>
-        <version>0.14.0-SNAPSHOT</version>
+        <version>0.18.0-SNAPSHOT</version>
     </parent>
 
     <artifactId>mcp-bom</artifactId>

mcp-core/pom.xml

@@ -6,7 +6,7 @@
 	<parent>
 		<groupId>io.modelcontextprotocol.sdk</groupId>
 		<artifactId>mcp-parent</artifactId>
-		<version>0.14.0-SNAPSHOT</version>
+		<version>0.18.0-SNAPSHOT</version>
 	</parent>
 	<artifactId>mcp-core</artifactId>
 	<packaging>jar</packaging>
@@ -68,7 +68,7 @@
         <dependency>
             <groupId>io.modelcontextprotocol.sdk</groupId>
             <artifactId>mcp-json</artifactId>
-            <version>0.14.0-SNAPSHOT</version>
+            <version>0.18.0-SNAPSHOT</version>
         </dependency>
 
 		<dependency>
@@ -101,7 +101,7 @@
         <dependency>
             <groupId>io.modelcontextprotocol.sdk</groupId>
             <artifactId>mcp-json-jackson2</artifactId>
-            <version>0.14.0-SNAPSHOT</version>
+            <version>0.18.0-SNAPSHOT</version>
             <scope>test</scope>
         </dependency>
 

mcp-core/src/main/java/io/modelcontextprotocol/client/LifecycleInitializer.java

@@ -11,14 +11,13 @@
 import java.util.concurrent.atomic.AtomicReference;
 import java.util.function.Function;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import io.modelcontextprotocol.spec.McpClientSession;
 import io.modelcontextprotocol.spec.McpError;
 import io.modelcontextprotocol.spec.McpSchema;
 import io.modelcontextprotocol.spec.McpTransportSessionNotFoundException;
 import io.modelcontextprotocol.util.Assert;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import reactor.core.publisher.Mono;
 import reactor.core.publisher.Sinks;
 import reactor.util.context.ContextView;
@@ -99,21 +98,30 @@ class LifecycleInitializer {
 	 */
 	private final Duration initializationTimeout;
 
+	/**
+	 * Post-initialization hook to perform additional operations after every successful
+	 * initialization.
+	 */
+	private final Function<Initialization, Mono<Void>> postInitializationHook;
+
 	public LifecycleInitializer(McpSchema.ClientCapabilities clientCapabilities, McpSchema.Implementation clientInfo,
 			List<String> protocolVersions, Duration initializationTimeout,
-			Function<ContextView, McpClientSession> sessionSupplier) {
+			Function<ContextView, McpClientSession> sessionSupplier,
+			Function<Initialization, Mono<Void>> postInitializationHook) {
 
 		Assert.notNull(sessionSupplier, "Session supplier must not be null");
 		Assert.notNull(clientCapabilities, "Client capabilities must not be null");
 		Assert.notNull(clientInfo, "Client info must not be null");
 		Assert.notEmpty(protocolVersions, "Protocol versions must not be empty");
 		Assert.notNull(initializationTimeout, "Initialization timeout must not be null");
+		Assert.notNull(postInitializationHook, "Post-initialization hook must not be null");
 
 		this.sessionSupplier = sessionSupplier;
 		this.clientCapabilities = clientCapabilities;
 		this.clientInfo = clientInfo;
 		this.protocolVersions = Collections.unmodifiableList(new ArrayList<>(protocolVersions));
 		this.initializationTimeout = initializationTimeout;
+		this.postInitializationHook = postInitializationHook;
 	}
 
 	/**
@@ -148,10 +156,6 @@ interface Initialization {
 
 	}
 
-	/**
-	 * Default implementation of the {@link Initialization} interface that manages the MCP
-	 * client initialization process.
-	 */
 	private static class DefaultInitialization implements Initialization {
 
 		/**
@@ -199,29 +203,20 @@ private void setMcpClientSession(McpClientSession mcpClientSession) {
 			this.mcpClientSession.set(mcpClientSession);
 		}
 
-		/**
-		 * Returns a Mono that completes when the MCP client initialization is complete.
-		 * This allows subscribers to wait for the initialization to finish before
-		 * proceeding with further operations.
-		 * @return A Mono that emits the result of the MCP initialization process
-		 */
 		private Mono<McpSchema.InitializeResult> await() {
 			return this.initSink.asMono();
 		}
 
-		/**
-		 * Completes the initialization process with the given result. It caches the
-		 * result and emits it to all subscribers waiting for the initialization to
-		 * complete.
-		 * @param initializeResult The result of the MCP initialization process
-		 */
 		private void complete(McpSchema.InitializeResult initializeResult) {
-			// first ensure the result is cached
-			this.result.set(initializeResult);
 			// inform all the subscribers waiting for the initialization
 			this.initSink.emitValue(initializeResult, Sinks.EmitFailureHandler.FAIL_FAST);
 		}
 
+		private void cacheResult(McpSchema.InitializeResult initializeResult) {
+			// first ensure the result is cached
+			this.result.set(initializeResult);
+		}
+
 		private void error(Throwable t) {
 			this.initSink.emitError(t, Sinks.EmitFailureHandler.FAIL_FAST);
 		}
@@ -263,7 +258,7 @@ public void handleException(Throwable t) {
 			}
 			// Providing an empty operation since we are only interested in triggering
 			// the implicit initialization step.
-			withIntitialization("re-initializing", result -> Mono.empty()).subscribe();
+			this.withInitialization("re-initializing", result -> Mono.empty()).subscribe();
 		}
 	}
 
@@ -275,28 +270,32 @@ public void handleException(Throwable t) {
 	 * @param operation The operation to execute when the client is initialized
 	 * @return A Mono that completes with the result of the operation
 	 */
-	public <T> Mono<T> withIntitialization(String actionName, Function<Initialization, Mono<T>> operation) {
+	public <T> Mono<T> withInitialization(String actionName, Function<Initialization, Mono<T>> operation) {
 		return Mono.deferContextual(ctx -> {
 			DefaultInitialization newInit = new DefaultInitialization();
 			DefaultInitialization previous = this.initializationRef.compareAndExchange(null, newInit);
 
 			boolean needsToInitialize = previous == null;
 			logger.debug(needsToInitialize ? "Initialization process started" : "Joining previous initialization");
 
-			Mono<McpSchema.InitializeResult> initializationJob = needsToInitialize ? doInitialize(newInit, ctx)
-					: previous.await();
+			Mono<McpSchema.InitializeResult> initializationJob = needsToInitialize
+					? this.doInitialize(newInit, this.postInitializationHook, ctx) : previous.await();
 
 			return initializationJob.map(initializeResult -> this.initializationRef.get())
 				.timeout(this.initializationTimeout)
 				.onErrorResume(ex -> {
 					this.initializationRef.compareAndSet(newInit, null);
 					return Mono.error(new RuntimeException("Client failed to initialize " + actionName, ex));
 				})
-				.flatMap(operation);
+				.flatMap(res -> operation.apply(res)
+					.contextWrite(c -> c.put(McpAsyncClient.NEGOTIATED_PROTOCOL_VERSION,
+							res.initializeResult().protocolVersion())));
 		});
 	}
 
-	private Mono<McpSchema.InitializeResult> doInitialize(DefaultInitialization initialization, ContextView ctx) {
+	private Mono<McpSchema.InitializeResult> doInitialize(DefaultInitialization initialization,
+			Function<Initialization, Mono<Void>> postInitOperation, ContextView ctx) {
+
 		initialization.setMcpClientSession(this.sessionSupplier.apply(ctx));
 
 		McpClientSession mcpClientSession = initialization.mcpSession();
@@ -322,7 +321,12 @@ private Mono<McpSchema.InitializeResult> doInitialize(DefaultInitialization init
 			}
 
 			return mcpClientSession.sendNotification(McpSchema.METHOD_NOTIFICATION_INITIALIZED, null)
+				.contextWrite(
+						c -> c.put(McpAsyncClient.NEGOTIATED_PROTOCOL_VERSION, initializeResult.protocolVersion()))
 				.thenReturn(initializeResult);
+		}).flatMap(initializeResult -> {
+			initialization.cacheResult(initializeResult);
+			return postInitOperation.apply(initialization).thenReturn(initializeResult);
 		}).doOnNext(initialization::complete).onErrorResume(ex -> {
 			initialization.error(ex);
 			return Mono.error(ex);