From f1af41acbc6414f96878b81a0617dcd7e5538f79 Mon Sep 17 00:00:00 2001
From: ak <a.kemalakcay@gmail.com>
Date: Wed, 28 Jan 2026 22:44:45 +0300
Subject: [PATCH 1/5] nit: prefer cannonical classes

---
 packages/components/src/components/badge/badge.tsx        | 8 ++++----
 .../components/src/components/code-group/dropdown.tsx     | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/packages/components/src/components/badge/badge.tsx b/packages/components/src/components/badge/badge.tsx
index cad4bbd..ad67059 100644
--- a/packages/components/src/components/badge/badge.tsx
+++ b/packages/components/src/components/badge/badge.tsx
@@ -125,13 +125,13 @@ const Badge = ({
   const commonProps = {
     "data-shape": shape,
     "data-variant": variant,
-    "data-disabled": disabled,
+    "data-disabled": disabled || undefined,
     className: cn(
-      'relative inline-flex w-fit items-center font-medium data-[disabled="true"]:cursor-not-allowed',
+      'relative inline-flex w-fit items-center font-medium data-disabled:cursor-not-allowed',
       "data-[shape='pill']:rounded-full",
       "data-[variant='outline']:outline-1 data-[variant='outline']:outline-[rgba(11,12,14,0.08)] data-[variant='outline']:outline-solid data-[variant='outline']:-outline-offset-1 dark:data-[variant='outline']:outline-[rgba(255,255,255,0.14)]",
-      'bg-(--color-bg) text-(--color-text) data-[disabled="true"]:bg-(--color-bg-disabled) data-[disabled="true"]:text-(--color-text-disabled)',
-      '[&_[data-component-part$="-icon"][data-icon-type="string"]_svg]:bg-(--color-text) data-[disabled="true"]:[&_[data-component-part$="-icon"][data-icon-type="string"]_svg]:bg-(--color-text-disabled)',
+      'bg-(--color-bg) text-(--color-text) data-disabled:bg-(--color-bg-disabled) data-disabled:text-(--color-text-disabled)',
+      '[&_[data-component-part$="-icon"][data-icon-type="string"]_svg]:bg-(--color-text) data-disabled:[&_[data-component-part$="-icon"][data-icon-type="string"]_svg]:bg-(--color-text-disabled)',
       '[&_[data-component-part$="-icon"][data-icon-type="inline"]_svg]:fill-current',
       sizeVariants[size],
       colorVariants[color],
diff --git a/packages/components/src/components/code-group/dropdown.tsx b/packages/components/src/components/code-group/dropdown.tsx
index ad49584..51c3ee9 100644
--- a/packages/components/src/components/code-group/dropdown.tsx
+++ b/packages/components/src/components/code-group/dropdown.tsx
@@ -83,7 +83,7 @@ const DropdownMenuItem = ({
 }: DropdownMenuItemProps) => (
   <Menu.Item
     className={cn(
-      "group relative flex w-full cursor-pointer select-none items-center justify-between gap-2 rounded-md px-2 py-1 text-sm outline-0 hover:bg-stone-950/[0.03] focus:bg-stone-950/5 data-[disabled]:pointer-events-none data-[disabled]:cursor-default data-[disabled]:opacity-50 dark:focus:bg-white/5 dark:hover:bg-white/[0.03]",
+      "group relative flex w-full cursor-pointer select-none items-center justify-between gap-2 rounded-md px-2 py-1 text-sm outline-0 hover:bg-stone-950/[0.03] focus:bg-stone-950/5 data-disabled:pointer-events-none data-disabled:cursor-default data-disabled:opacity-50 dark:focus:bg-white/5 dark:hover:bg-white/[0.03]",
       isSelected
         ? "font-medium text-primary dark:text-primary-light"
         : "text-stone-950/50 hover:text-stone-950/75 focus:text-stone-950/75 dark:text-white/50 dark:focus:text-white/75 dark:hover:text-white/75",

From 20f6d620b7f68f9087cbf64bb96ba4810547bbfa Mon Sep 17 00:00:00 2001
From: ak <a.kemalakcay@gmail.com>
Date: Fri, 30 Jan 2026 15:20:37 +0300
Subject: [PATCH 2/5] nit: remove unnecessary quotes from data attribute
 selectors

---
 packages/components/src/components/badge/badge.tsx | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/packages/components/src/components/badge/badge.tsx b/packages/components/src/components/badge/badge.tsx
index ad67059..f5708c4 100644
--- a/packages/components/src/components/badge/badge.tsx
+++ b/packages/components/src/components/badge/badge.tsx
@@ -20,10 +20,10 @@ type BadgeColor =
   | "surface-destructive";
 
 const sizeVariants: Record<BadgeSize, string> = {
-  lg: 'gap-1 py-1 pl-2.5 pr-2.5 [&_svg]:size-3.5 text-sm tracking-[-0.1px] data-[shape="rounded"]:rounded-[8px]',
-  md: 'gap-1 py-0.5 pl-2 pr-2 [&_svg]:size-3.5 text-sm tracking-[-0.1px] data-[shape="rounded"]:rounded-[8px]',
-  sm: 'gap-[3px] py-0.5 pl-1.5 pr-1.5 [&_svg]:size-3 text-xs data-[shape="rounded"]:rounded-[6px]',
-  xs: 'gap-0.5 py-0 pl-1 pr-1 [&_svg]:size-2.5 text-xs data-[shape="rounded"]:rounded-[4px]',
+  lg: 'gap-1 py-1 pl-2.5 pr-2.5 [&_svg]:size-3.5 text-sm tracking-[-0.1px] data-[shape=rounded]:rounded-[8px]',
+  md: 'gap-1 py-0.5 pl-2 pr-2 [&_svg]:size-3.5 text-sm tracking-[-0.1px] data-[shape=rounded]:rounded-[8px]',
+  sm: 'gap-[3px] py-0.5 pl-1.5 pr-1.5 [&_svg]:size-3 text-xs data-[shape=rounded]:rounded-[6px]',
+  xs: 'gap-0.5 py-0 pl-1 pr-1 [&_svg]:size-2.5 text-xs data-[shape=rounded]:rounded-[4px]',
 };
 
 const colorVariants: Record<BadgeColor, string> = {
@@ -128,8 +128,8 @@ const Badge = ({
     "data-disabled": disabled || undefined,
     className: cn(
       'relative inline-flex w-fit items-center font-medium data-disabled:cursor-not-allowed',
-      "data-[shape='pill']:rounded-full",
-      "data-[variant='outline']:outline-1 data-[variant='outline']:outline-[rgba(11,12,14,0.08)] data-[variant='outline']:outline-solid data-[variant='outline']:-outline-offset-1 dark:data-[variant='outline']:outline-[rgba(255,255,255,0.14)]",
+      "data-[shape=pill]:rounded-full",
+      "data-[variant=outline]:outline-1 data-[variant=outline]:outline-[rgba(11,12,14,0.08)] data-[variant=outline]:outline-solid data-[variant=outline]:-outline-offset-1 dark:data-[variant=outline]:outline-[rgba(255,255,255,0.14)]",
       'bg-(--color-bg) text-(--color-text) data-disabled:bg-(--color-bg-disabled) data-disabled:text-(--color-text-disabled)',
       '[&_[data-component-part$="-icon"][data-icon-type="string"]_svg]:bg-(--color-text) data-disabled:[&_[data-component-part$="-icon"][data-icon-type="string"]_svg]:bg-(--color-text-disabled)',
       '[&_[data-component-part$="-icon"][data-icon-type="inline"]_svg]:fill-current',

From d21f851c516664b36975a1df6268897aa2cfb4f4 Mon Sep 17 00:00:00 2001
From: ak <a.kemalakcay@gmail.com>
Date: Fri, 30 Jan 2026 15:21:38 +0300
Subject: [PATCH 3/5] Revert "nit: remove unnecessary quotes from data
 attribute selectors"

This reverts commit 20f6d620b7f68f9087cbf64bb96ba4810547bbfa.
---
 packages/components/src/components/badge/badge.tsx | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/packages/components/src/components/badge/badge.tsx b/packages/components/src/components/badge/badge.tsx
index f5708c4..ad67059 100644
--- a/packages/components/src/components/badge/badge.tsx
+++ b/packages/components/src/components/badge/badge.tsx
@@ -20,10 +20,10 @@ type BadgeColor =
   | "surface-destructive";
 
 const sizeVariants: Record<BadgeSize, string> = {
-  lg: 'gap-1 py-1 pl-2.5 pr-2.5 [&_svg]:size-3.5 text-sm tracking-[-0.1px] data-[shape=rounded]:rounded-[8px]',
-  md: 'gap-1 py-0.5 pl-2 pr-2 [&_svg]:size-3.5 text-sm tracking-[-0.1px] data-[shape=rounded]:rounded-[8px]',
-  sm: 'gap-[3px] py-0.5 pl-1.5 pr-1.5 [&_svg]:size-3 text-xs data-[shape=rounded]:rounded-[6px]',
-  xs: 'gap-0.5 py-0 pl-1 pr-1 [&_svg]:size-2.5 text-xs data-[shape=rounded]:rounded-[4px]',
+  lg: 'gap-1 py-1 pl-2.5 pr-2.5 [&_svg]:size-3.5 text-sm tracking-[-0.1px] data-[shape="rounded"]:rounded-[8px]',
+  md: 'gap-1 py-0.5 pl-2 pr-2 [&_svg]:size-3.5 text-sm tracking-[-0.1px] data-[shape="rounded"]:rounded-[8px]',
+  sm: 'gap-[3px] py-0.5 pl-1.5 pr-1.5 [&_svg]:size-3 text-xs data-[shape="rounded"]:rounded-[6px]',
+  xs: 'gap-0.5 py-0 pl-1 pr-1 [&_svg]:size-2.5 text-xs data-[shape="rounded"]:rounded-[4px]',
 };
 
 const colorVariants: Record<BadgeColor, string> = {
@@ -128,8 +128,8 @@ const Badge = ({
     "data-disabled": disabled || undefined,
     className: cn(
       'relative inline-flex w-fit items-center font-medium data-disabled:cursor-not-allowed',
-      "data-[shape=pill]:rounded-full",
-      "data-[variant=outline]:outline-1 data-[variant=outline]:outline-[rgba(11,12,14,0.08)] data-[variant=outline]:outline-solid data-[variant=outline]:-outline-offset-1 dark:data-[variant=outline]:outline-[rgba(255,255,255,0.14)]",
+      "data-[shape='pill']:rounded-full",
+      "data-[variant='outline']:outline-1 data-[variant='outline']:outline-[rgba(11,12,14,0.08)] data-[variant='outline']:outline-solid data-[variant='outline']:-outline-offset-1 dark:data-[variant='outline']:outline-[rgba(255,255,255,0.14)]",
       'bg-(--color-bg) text-(--color-text) data-disabled:bg-(--color-bg-disabled) data-disabled:text-(--color-text-disabled)',
       '[&_[data-component-part$="-icon"][data-icon-type="string"]_svg]:bg-(--color-text) data-disabled:[&_[data-component-part$="-icon"][data-icon-type="string"]_svg]:bg-(--color-text-disabled)',
       '[&_[data-component-part$="-icon"][data-icon-type="inline"]_svg]:fill-current',

From dba07f29996889be3ece761c3bf2026228875875 Mon Sep 17 00:00:00 2001
From: ak <a.kemalakcay@gmail.com>
Date: Fri, 30 Jan 2026 15:24:15 +0300
Subject: [PATCH 4/5] nit: prefer canonical opacity shorthand

---
 packages/components/src/components/code-group/dropdown.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/components/src/components/code-group/dropdown.tsx b/packages/components/src/components/code-group/dropdown.tsx
index 51c3ee9..ef359e7 100644
--- a/packages/components/src/components/code-group/dropdown.tsx
+++ b/packages/components/src/components/code-group/dropdown.tsx
@@ -83,7 +83,7 @@ const DropdownMenuItem = ({
 }: DropdownMenuItemProps) => (
   <Menu.Item
     className={cn(
-      "group relative flex w-full cursor-pointer select-none items-center justify-between gap-2 rounded-md px-2 py-1 text-sm outline-0 hover:bg-stone-950/[0.03] focus:bg-stone-950/5 data-disabled:pointer-events-none data-disabled:cursor-default data-disabled:opacity-50 dark:focus:bg-white/5 dark:hover:bg-white/[0.03]",
+      "group relative flex w-full cursor-pointer select-none items-center justify-between gap-2 rounded-md px-2 py-1 text-sm outline-0 hover:bg-stone-950/3 focus:bg-stone-950/5 data-disabled:pointer-events-none data-disabled:cursor-default data-disabled:opacity-50 dark:focus:bg-white/5 dark:hover:bg-white/3",
       isSelected
         ? "font-medium text-primary dark:text-primary-light"
         : "text-stone-950/50 hover:text-stone-950/75 focus:text-stone-950/75 dark:text-white/50 dark:focus:text-white/75 dark:hover:text-white/75",

From 6bfe05b0f0b1957472ae87522416f27e42ceec98 Mon Sep 17 00:00:00 2001
From: ak <a.kemalakcay@gmail.com>
Date: Fri, 30 Jan 2026 16:24:45 +0300
Subject: [PATCH 5/5] lint

---
 packages/components/src/components/badge/badge.tsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/components/src/components/badge/badge.tsx b/packages/components/src/components/badge/badge.tsx
index ad67059..d5ef217 100644
--- a/packages/components/src/components/badge/badge.tsx
+++ b/packages/components/src/components/badge/badge.tsx
@@ -127,10 +127,10 @@ const Badge = ({
     "data-variant": variant,
     "data-disabled": disabled || undefined,
     className: cn(
-      'relative inline-flex w-fit items-center font-medium data-disabled:cursor-not-allowed',
+      "relative inline-flex w-fit items-center font-medium data-disabled:cursor-not-allowed",
       "data-[shape='pill']:rounded-full",
       "data-[variant='outline']:outline-1 data-[variant='outline']:outline-[rgba(11,12,14,0.08)] data-[variant='outline']:outline-solid data-[variant='outline']:-outline-offset-1 dark:data-[variant='outline']:outline-[rgba(255,255,255,0.14)]",
-      'bg-(--color-bg) text-(--color-text) data-disabled:bg-(--color-bg-disabled) data-disabled:text-(--color-text-disabled)',
+      "bg-(--color-bg) text-(--color-text) data-disabled:bg-(--color-bg-disabled) data-disabled:text-(--color-text-disabled)",
       '[&_[data-component-part$="-icon"][data-icon-type="string"]_svg]:bg-(--color-text) data-disabled:[&_[data-component-part$="-icon"][data-icon-type="string"]_svg]:bg-(--color-text-disabled)',
       '[&_[data-component-part$="-icon"][data-icon-type="inline"]_svg]:fill-current',
       sizeVariants[size],