Skip to content

Commit 90eb5db

Browse files
committed
refactor: prepare for removal of read and write from MocketSocket
1 parent 0eff8f1 commit 90eb5db

2 files changed

Lines changed: 13 additions & 9 deletions

File tree

mocket/socket.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -269,9 +269,13 @@ def recv_into(
269269
flags: int | None = None,
270270
) -> int:
271271
if hasattr(buffer, "write"):
272-
return buffer.write(self.read(buffersize))
272+
return buffer.write(self.recv(buffersize))
273+
273274
# buffer is a memoryview
274-
data = self.read(buffersize)
275+
if buffersize is None:
276+
buffersize = len(buffer)
277+
278+
data = self.recv(buffersize)
275279
if data:
276280
buffer[: len(data)] = data
277281
return len(data)
@@ -280,7 +284,7 @@ def recv(self, buffersize: int, flags: int | None = None) -> bytes:
280284
r_fd, _ = Mocket.get_pair((self._host, self._port))
281285
if r_fd:
282286
return os.read(r_fd, buffersize)
283-
data = self.read(buffersize)
287+
data = self.io.read(buffersize)
284288
if data:
285289
return data
286290
# used by Redis mock

tests/test_http.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -359,12 +359,12 @@ def test_sockets(self):
359359
sock = socket.socket(address[0], address[1], address[2])
360360

361361
sock.connect(address[-1])
362-
sock.write(f"{method} {path} HTTP/1.0\r\n")
363-
sock.write(f"Host: {host}\r\n")
364-
sock.write("Content-Type: application/json\r\n")
365-
sock.write("Content-Length: %d\r\n" % len(data))
366-
sock.write("Connection: close\r\n\r\n")
367-
sock.write(data)
362+
sock.send(f"{method} {path} HTTP/1.0\r\n".encode())
363+
sock.send(f"Host: {host}\r\n".encode())
364+
sock.send(b"Content-Type: application/json\r\n")
365+
sock.send(b"Content-Length: %d\r\n" % len(data))
366+
sock.send(b"Connection: close\r\n\r\n")
367+
sock.send(data.encode())
368368
sock.close()
369369

370370
# Proof that worked.

0 commit comments

Comments
 (0)