✨ add to job information

Author: ianardee

src/v2/parsing/job/job.ts

@@ -16,9 +16,13 @@ export class Job {
    */
   public error?: ErrorResponse;
   /**
-   * Timestamp of the job creation.
+   * Date and time of the Job creation.
    */
   public createdAt: Date | null;
+  /**
+   * Date and time of the Job completion. Filled once processing is finished.
+   */
+  public completedAt: Date | null | undefined;
   /**
    * ID of the model.
    */
@@ -53,19 +57,22 @@ export class Job {
     if (serverResponse["status"] !== undefined) {
       this.status = serverResponse["status"];
     }
-    if (
-      serverResponse["error"] !== undefined &&
-      serverResponse["error"] !== null &&
-      Object.keys(serverResponse["error"]).length > 0
-    ) {
+    if (serverResponse["error"]) {
       this.error = new ErrorResponse(serverResponse["error"]);
     }
     this.createdAt = parseDate(serverResponse["created_at"]);
+    if (!serverResponse["completed_at"]) {
+      this.completedAt = undefined;
+    } else {
+      this.completedAt = parseDate(serverResponse["completed_at"]);
+    }
     this.modelId = serverResponse["model_id"];
     this.pollingUrl = serverResponse["polling_url"];
     this.filename = serverResponse["filename"];
     this.resultUrl = serverResponse["result_url"];
     this.alias = serverResponse["alias"];
-    this.webhooks = serverResponse["webhooks"];
+    this.webhooks = (serverResponse["webhooks"] ?? []).map(
+      (webhook: StringDict) => new JobWebhook(webhook)
+    );
   }
 }

src/v2/parsing/job/jobWebhook.ts

@@ -26,7 +26,7 @@ export class JobWebhook {
     this.id = serverResponse["id"];
     this.createdAt = parseDate(serverResponse["created_at"]);
     this.status = serverResponse["status"];
-    if (serverResponse["error"] !== undefined) {
+    if (serverResponse["error"]) {
       this.error = new ErrorResponse(serverResponse["error"]);
     }
   }

tests/v2/parsing/job.spec.ts

@@ -18,21 +18,43 @@ async function loadV2Job(resourcePath: string): Promise<JobResponse> {
 }
 
 describe("MindeeV2 - Job Response", async () => {
+
   describe("Success", async () => {
     it("should load when status is Processing", async () => {
       const response = await loadV2Job(
         path.join(jobPath, "ok_processing.json")
       );
       assert.ok(response.job);
+      assert.strictEqual(response.job.status, "Processing");
+      assert.ok(response.job.createdAt instanceof Date);
+      assert.strictEqual(response.job.completedAt, undefined);
+      assert.strictEqual(response.job.error, undefined);
+    });
+
+    it("should load when status is Processed", async () => {
+      const response = await loadV2Job(
+        path.join(jobPath, "ok_processed_webhooks_ok.json")
+      );
+      assert.ok(response.job);
+      assert.strictEqual(response.job.status, "Processed");
+      assert.ok(response.job.createdAt instanceof Date);
+      assert.ok(response.job.completedAt instanceof Date);
       assert.strictEqual(response.job.error, undefined);
+      response.job.webhooks.forEach((webhook) => {
+        assert.ok(webhook.id);
+        assert.ok(webhook.createdAt instanceof Date);
+      });
     });
   });
+
   describe("Failure", async () => {
     it("should load with 422 error", async () => {
       const response = await loadV2Job(
         path.join(jobPath, "fail_422.json")
       );
       assert.ok(response.job);
+      assert.ok(response.job.createdAt instanceof Date);
+      assert.ok(response.job.completedAt instanceof Date);
       assert.ok(response.job.error instanceof ErrorResponse);
       assert.strictEqual(response.job.error?.status, 422);
       assert.ok(response.job.error?.code.startsWith("422-"));