Skip to content

Commit f86121d

Browse files
ianardeeianardee
committed
fix warnings
1 parent 3120822 commit f86121d

File tree

5 files changed

+26
-34
lines changed

5 files changed

+26
-34
lines changed

‎pom.xml‎

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@
9090
<version>${org.projectlombok.lombok-mapstruct-binding.version}</version>
9191
</path>
9292
</annotationProcessorPaths>
93-
<source>11</source>
94-
<target>11</target>
93+
<source>${compiler.source}</source>
94+
<target>${compiler.target}</target>
9595
</configuration>
9696
</plugin>
9797
<plugin>
@@ -102,7 +102,7 @@
102102
<linkXRef>false</linkXRef>
103103
<printFailingErrors>true</printFailingErrors>
104104
<failurePriority>3</failurePriority>
105-
<targetJdk>11</targetJdk>
105+
<targetJdk>${compiler.target}</targetJdk>
106106
</configuration>
107107
</plugin>
108108
<plugin>
@@ -129,8 +129,8 @@
129129
<groupId>org.apache.maven.plugins</groupId>
130130
<artifactId>maven-compiler-plugin</artifactId>
131131
<configuration>
132-
<source>${maven.compiler.source}</source>
133-
<target>${maven.compiler.target}</target>
132+
<source>${compiler.source}</source>
133+
<target>${compiler.target}</target>
134134
</configuration>
135135
</plugin>
136136
<plugin>
@@ -340,12 +340,6 @@
340340
<scope>test</scope>
341341
<version>${org.junit.jupiter.version}</version>
342342
</dependency>
343-
<dependency>
344-
<artifactId>junit-platform-suite</artifactId>
345-
<groupId>org.junit.platform</groupId>
346-
<scope>test</scope>
347-
<version>${org.junit.platform.version}</version>
348-
</dependency>
349343
<dependency>
350344
<artifactId>junit-pioneer</artifactId>
351345
<groupId>org.junit-pioneer</groupId>
@@ -393,8 +387,8 @@
393387
</surefire.addOpens>
394388

395389
<!-- Minimum Java version -->
396-
<maven.compiler.source>11</maven.compiler.source>
397-
<maven.compiler.target>11</maven.compiler.target>
390+
<compiler.source>11</compiler.source>
391+
<compiler.target>11</compiler.target>
398392

399393
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
400394

@@ -409,7 +403,7 @@
409403
<org.apache.pdfbox.version>3.0.7</org.apache.pdfbox.version>
410404
<org.mapstruct.version>1.5.3.Final</org.mapstruct.version>
411405
<org.projectlombok.lombok-mapstruct-binding.version>0.2.0</org.projectlombok.lombok-mapstruct-binding.version>
412-
<org.projectlombok.version>1.18.38</org.projectlombok.version>
406+
<org.projectlombok.version>1.18.40</org.projectlombok.version>
413407
<org.slf4j.version>2.0.17</org.slf4j.version>
414408

415409
<!-- Build/Test dependencies -->
@@ -424,10 +418,10 @@
424418
<org.apache.maven.project.info.reports.version>3.0.0</org.apache.maven.project.info.reports.version>
425419
<org.apache.maven.site.version>3.7.1</org.apache.maven.site.version>
426420
<org.apache.maven.surfire.version>3.5.5</org.apache.maven.surfire.version>
427-
<org.junit.jupiter.version>5.8.2</org.junit.jupiter.version>
428-
<org.junit.pioneer.version>1.9.1</org.junit.pioneer.version>
429-
<org.junit.platform.version>1.9.2</org.junit.platform.version>
430421
<wiremock.version>3.13.2</wiremock.version>
422+
<!-- jupiter version 5.x is the last with JRE 11 support -->
423+
<org.junit.jupiter.version>5.11.4</org.junit.jupiter.version>
424+
<org.junit.pioneer.version>2.3.0</org.junit.pioneer.version>
431425
</properties>
432426

433427
</project>

‎src/main/java/com/mindee/v1/parsing/LocalResponse.java‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ private <P extends Inference, R> R deserialize(
6262
public <T extends Inference> AsyncPredictResponse<T> deserializeAsyncResponse(
6363
Class<T> productClass
6464
) throws IOException {
65+
@SuppressWarnings("unchecked")
6566
AsyncPredictResponse<T> response = deserialize(AsyncPredictResponse.class, productClass);
6667
response.setRawResponse(new String(this.file, StandardCharsets.UTF_8));
6768
return response;
@@ -78,6 +79,7 @@ public <T extends Inference> AsyncPredictResponse<T> deserializeAsyncResponse(
7879
public <T extends Inference> PredictResponse<T> deserializeSyncResponse(
7980
Class<T> productClass
8081
) throws IOException {
82+
@SuppressWarnings("unchecked")
8183
PredictResponse<T> response = deserialize(PredictResponse.class, productClass);
8284
response.setRawResponse(new String(this.file, StandardCharsets.UTF_8));
8385
return response;

‎src/main/java/com/mindee/v1/parsing/generated/GeneratedObject.java‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public StringField asStringField() {
3636
* @return An {@link AmountField} containing a double value.
3737
*/
3838
public AmountField asAmountField() {
39-
Double value;
39+
double value;
4040
Object rawValue = this.get("value");
4141
if (rawValue instanceof Integer) {
4242
value = ((Integer) rawValue).doubleValue();
@@ -109,13 +109,13 @@ public Polygon getAsPolygon(String key) {
109109
if (!this.containsKey(key)) {
110110
return null;
111111
}
112-
Object rawPolygon = this.get(key);
112+
var rawPolygon = this.get(key);
113113
// a valid polygon must have at least 4 points
114114
if (!(rawPolygon instanceof List && ((List<?>) rawPolygon).size() >= 4)) {
115115
return null;
116116
}
117117
// a valid point must have exactly 2 coordinates
118-
for (Object point : (List<?>) rawPolygon) {
118+
for (var point : (List<?>) rawPolygon) {
119119
if (!(point instanceof List) || ((List<?>) point).size() != 2) {
120120
return null;
121121
}
@@ -125,7 +125,9 @@ public Polygon getAsPolygon(String key) {
125125
}
126126
}
127127
}
128-
return new Polygon((List<List<Double>>) rawPolygon);
128+
@SuppressWarnings("unchecked")
129+
List<List<Double>> points = (List<List<Double>>) rawPolygon;
130+
return new Polygon(points);
129131
}
130132

131133
/**

‎src/main/java/com/mindee/v1/parsing/generated/GeneratedV1PredictionDeserializer.java‎

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,11 @@
33
import com.fasterxml.jackson.core.JsonParser;
44
import com.fasterxml.jackson.databind.DeserializationContext;
55
import com.fasterxml.jackson.databind.JsonNode;
6-
import com.fasterxml.jackson.databind.ObjectMapper;
76
import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
87
import com.fasterxml.jackson.databind.node.ObjectNode;
98
import com.mindee.v1.product.generated.GeneratedV1Document;
109
import java.io.IOException;
1110
import java.util.HashMap;
12-
import java.util.Iterator;
13-
import java.util.Map;
1411

1512
/**
1613
* JSON deserializer for generated documents v1.x.
@@ -21,8 +18,6 @@ public GeneratedV1PredictionDeserializer(Class<?> vc) {
2118
super(vc);
2219
}
2320

24-
private static final ObjectMapper mapper = new ObjectMapper();
25-
2621
public GeneratedV1PredictionDeserializer() {
2722
this(null);
2823
}
@@ -32,15 +27,14 @@ public GeneratedV1Document deserialize(
3227
JsonParser jsonParser,
3328
DeserializationContext deserializationContext
3429
) throws IOException {
35-
ObjectNode rootNode = jsonParser.getCodec().readTree(jsonParser);
36-
Map<String, GeneratedFeature> features = new HashMap<>();
30+
var mapper = jsonParser.getCodec();
31+
ObjectNode rootNode = mapper.readTree(jsonParser);
32+
var features = new HashMap<String, GeneratedFeature>();
3733

38-
for (Iterator<Map.Entry<String, JsonNode>> subNode = rootNode.fields(); subNode.hasNext();) {
39-
Map.Entry<String, JsonNode> featureNode = subNode.next();
34+
for (var featureNode : rootNode.properties()) {
4035
String featureName = featureNode.getKey();
4136

4237
GeneratedFeature feature;
43-
4438
if (featureNode.getValue().isArray()) {
4539
feature = new GeneratedFeature(true);
4640
for (JsonNode item : featureNode.getValue()) {

‎src/main/java/com/mindee/v2/parsing/inference/field/DynamicField.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,13 @@ public ObjectField getObjectField() throws IllegalStateException {
8282
*/
8383
public <T extends BaseField> T getField(Class<T> type) throws IllegalArgumentException {
8484
if (type == SimpleField.class) {
85-
return (T) this.getSimpleField();
85+
return type.cast(this.getSimpleField());
8686
}
8787
if (type == ListField.class) {
88-
return (T) this.getListField();
88+
return type.cast(this.getListField());
8989
}
9090
if (type == ObjectField.class) {
91-
return (T) this.getObjectField();
91+
return type.cast(this.getObjectField());
9292
}
9393
throw new IllegalArgumentException("Cannot cast to " + type.getSimpleName());
9494
}

0 commit comments

Comments
 (0)